QField 💖 QML & HTML #1221
QField 💖 QML & HTML #1221
Conversation
|
BTW, the QML widget in the GIF nicely occupies the available width in QField: The way you set this up is by using the following declaration in the QML widget source code: Users can't simply use parent.width as in QGIS, the parent is a QQuickRootItem, which doesn't have a width value. Since there's no proper way to check whether a QML item is a root or not, we can check whether the parent has a parent (if it doesn't, it's the root). |
src/core/featuremodel.cpp
Outdated
| @@ -49,7 +49,7 @@ FeatureModel::ModelModes FeatureModel::modelMode() const | |||
|
|
|||
| void FeatureModel::setFeature( const QgsFeature &feature ) | |||
| { | |||
| if ( mModelMode != SingleFeatureModel || mFeature == feature ) | |||
| if ( mModelMode != SingleFeatureModel ) | |||
There was a problem hiding this comment.
To trigger a refresh when the feature is modified. If you look into FeatureModel::save(), you'll see it calls setFeature( modifiedFeature ), which ended up doing nothing as mFeature == modifiedFeature will be true even if the modifiedFeature has different attribute values et al.
There was a problem hiding this comment.
is it worth adding a bool force = false argument to the method?
There was a problem hiding this comment.
Na, I've seen other weird behaviors which is fixed by this removed check. So I'd prefer just removing it all together.
There was a problem hiding this comment.
as mFeature == modifiedFeature will be true even if the modifiedFeature has different attribute values et al.
According to QgsFeatore::operator== attributes should be compared as well. What did I miss?
There was a problem hiding this comment.
https://github.com/qgis/QGIS/blob/master/src/core/qgsfeature.cpp#L68
I am no expert, but I would like to avoid having setters being executed too many times. It makes the debugging more difficult and might be noticeable by the user (rendering time, flickering).
but that's not my call to make here.
|
BTW, animations also work, can make for nice attention grabbing elements, e.g.: |
|
HTML widget support added: |
|
@m-kuhn , I think we might have a bit of work to do on the osgeo4a side of things to add the QML WebView module. |
|
@m-kuhn , I suspect a similar update will be required for QML charts module too. See how the QML chart widget is missing when testing on my smartphone: |
nirvn
force-pushed
the
qml
branch
2 times, most recently
from
f739e28 to
0f031eb
Compare
|
@m-kuhn , this is all green and ready to approve. |
This PR implements QML widget support in the feature form. An obligatory GIF:
As the above screencast demonstrates, the current implementation QField supports expression.evaluate(...). The method I've settled on to do it (i.e. string substitution in the QML source string) was the most appropriate solution I could come up with. On the plus side, the general idea behind it can easily be used to come up with an HTML widget support (via the WebView item).