feat: add more validation to resource.router and add test cases #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
karrui
changed the title
Datadog ReportBranch report: ✅ 0 Failed, 129 Passed, 23 Skipped, 25.76s Total Time |
|
This PR breaks frontend for now since frontend calls the |
seaerchin
approved these changes
Oct 11, 2024
| expect(result).toMatchObject(expected) | ||
| }) | ||
|
|
||
| it.skip("should throw 403 if user does not have write access to destination resource", async () => {}) |
There was a problem hiding this comment.
we might need 1 more (skipped) test case: admin can move folders/pages from anywhere to root
| it.skip("should throw 403 if user does not have read access to the resource", async () => {}) | ||
| }) | ||
|
|
||
| describe("delete", () => { |
There was a problem hiding this comment.
need a test case checking that the user cannot delete the root page
karrui
force-pushed
the
page_router_tests
branch
from
f69ee9e to
c768018
Compare
karrui
force-pushed
the
resource_router_tests
branch
from
3491a2d to
420cf2e
Compare
This was referenced Oct 11, 2024
karrui
force-pushed
the
resource_router_tests
branch
from
420cf2e to
d81f89e
Compare
karrui
force-pushed
the
resource_router_tests
branch
from
d81f89e to
dcfaa42
Compare
Merge activity
|
karrui
force-pushed
the
resource_router_tests
branch
from
dcfaa42 to
b03df30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of the PR. This PR adds tests for
resource.routerBlocked by #729