Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aws-actions/amazon-ecs-deploy-task-definition to v2 #978

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

adriangohjw
Copy link
Contributor

Problem

re: https://opengovproducts.slack.com/archives/CK9GGK6EP/p1736350549788019

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • bump from v1 to v2

Tests

  • should be able to deploy studio to staging/prod/uat successfully

@adriangohjw adriangohjw self-assigned this Jan 9, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 9, 2025 00:01
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 9, 2025

Datadog Report

Branch report: gh-action-bump-aws-ecs-to-v2
Commit report: 49fece7
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 46.42s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@harishv7 harishv7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test on staging first

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Feb 3, 2025

Datadog Report

Branch report: gh-action-bump-aws-ecs-to-v2
Commit report: a96e717
Test service: isomer-studio

✅ 0 Failed, 266 Passed, 36 Skipped, 47.81s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit 71689f1 into main Feb 3, 2025
24 checks passed
@adriangohjw adriangohjw deleted the gh-action-bump-aws-ecs-to-v2 branch February 3, 2025 21:10
@adriangohjw
Copy link
Contributor Author

tested on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants