Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/add user email in studio #999

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

adriangohjw
Copy link
Contributor

Problem

Feedback from agencies about not knowing which email they are using

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Improvements:

  • add me.email to the dropdown
  • refactor to be reusable between different navbars
  • add stories

Before & After Screenshots

image

Tests

  1. click on avatar menu in both Sites Management page / AND resource management page /sites/XXX
  2. it should show your email - no behaviour on hover + non-clickable

@adriangohjw adriangohjw added the enhancement New feature or request label Jan 18, 2025
@adriangohjw adriangohjw self-assigned this Jan 18, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 18, 2025 17:57
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 18, 2025

Datadog Report

Branch report: enhancement/add-user-email-in-studio
Commit report: 01d08d1
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 46.07s Total Time
➡️ Test Sessions change in coverage: 1 no change

apps/studio/src/components/AvatarMenu.tsx Outdated Show resolved Hide resolved
apps/studio/src/components/AvatarMenu.tsx Outdated Show resolved Hide resolved
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 31, 2025

Datadog Report

Branch report: enhancement/add-user-email-in-studio
Commit report: d19f5ac
Test service: isomer-studio

✅ 0 Failed, 266 Passed, 36 Skipped, 48.91s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw enabled auto-merge (squash) February 3, 2025 05:07
@adriangohjw adriangohjw disabled auto-merge February 3, 2025 05:12
@adriangohjw adriangohjw merged commit 76f2119 into main Feb 3, 2025
17 checks passed
@adriangohjw adriangohjw deleted the enhancement/add-user-email-in-studio branch February 3, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants