Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exec:exec instead of exec:java goal to avoid classloaders leak #2432

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Use exec:exec instead of exec:java goal to avoid classloaders leak #2432

merged 1 commit into from
Aug 23, 2021
+72 −48

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jul 20, 2021

This should help a lot as a workaround to apache/maven-mvnd#440 which has no real fix.

@gnodet gnodet requested a review from a team as a code owner July 20, 2021 11:03
@gnodet gnodet mentioned this pull request Jul 20, 2021
Closed
@gnodet
Copy link
Contributor Author

gnodet commented Jul 27, 2021

@rogierhofboer can you have a look and see if this helps with apache/maven-mvnd#440 ?

@rogierhofboer
Copy link

@gnodet This fixes the problem for me. But shouldn't it also work with java instead of exec?

@gnodet
Copy link
Contributor Author

gnodet commented Jul 27, 2021

Yes, it should work with java, but the problems is not in mvnd, rather in the invoked java code, in this case, the eclipse EMF generator. So you can raise an issue on their side, but I can't do anything in mvnd if they keep references to the classloaders somehow.

@kaikreuzer
Copy link
Member

Thanks for this fix @gnodet! May I ask you to sign-off your commit as per our contribution guidelines? Thanks!

@gnodet
Copy link
Contributor Author

gnodet commented Aug 23, 2021 •
edited
Loading

Thanks for this fix @gnodet! May I ask you to sign-off your commit as per our contribution guidelines? Thanks!

@kaikreuzer Done !

kaikreuzer
kaikreuzer approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot!

@kaikreuzer kaikreuzer merged commit 43330c4 into openhab:main Aug 23, 2021
@wborn wborn added this to the 3.2 milestone Aug 31, 2021
ghys pushed a commit to ghys/openhab-core that referenced this pull request Sep 9, 2021
@gnodet @ghys
Use exec:exec instead of exec:java goal to avoid classloaders leak (o…
d7a4c6c 
…penhab#2432) (openhab#2432)

Signed-off-by: Guillaume Nodet <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@gnodet @splatch
Use exec:exec instead of exec:java goal to avoid classloaders leak (o…
722b41a 
…penhab#2432) (openhab#2432)

Signed-off-by: Guillaume Nodet <[email protected]>
GitOrigin-RevId: 43330c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnodet @rogierhofboer @kaikreuzer @wborn