Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Expose UI command handling to native wrappers #2622

Merged
merged 5 commits into from
Jun 24, 2024
Merged

[MainUI] Expose UI command handling to native wrappers #2622

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
204f223
[MainUI] exposes navigation commands to native wrappers
digitaldan Jun 24, 2024
48c9f55
Update bundles/org.openhab.ui/web/src/components/sse-events-mixin.js
digitaldan Jun 24, 2024
5d4af8f
PR review changes
digitaldan Jun 24, 2024
1eef3d9
PR review changes
digitaldan Jun 24, 2024
9ed8058
Naming changes
digitaldan Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bundles/org.openhab.ui/web/src/components/sse-events-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default {
break
case topicCommand:
const payload = JSON.parse(event.payload)
this.navigate(payload)
this.handleCommand(payload.value)
break
}
})
Expand Down Expand Up @@ -104,9 +104,9 @@ export default {
this.$f7.sheet.close(sheetEl)
}
},
navigate (navigationString) {
console.log('Navigating: ' + navigationString)
const [command, ...segments] = navigationString.trim().split(':') // NOT use a RegEx lookbehind assertions here, because they are unsupported on Safari < 16.4, i.e. iOS 15.x
handleCommand (commandString) {
console.log('Navigating: ' + commandString)
digitaldan marked this conversation as resolved.
Show resolved Hide resolved
const [command, ...segments] = commandString.trim().split(':') // NOT use a RegEx lookbehind assertions here, because they are unsupported on Safari < 16.4, i.e. iOS 15.x
const combined = segments.join(':')
switch (command) {
case 'navigate':
Expand Down