Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: choose whether to push group messages offline based on the user's session option settings #1054

Merged
merged 21 commits into from
Sep 11, 2023

Conversation

withchao
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1044

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2023
@withchao withchao temporarily deployed to openim September 11, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 07:15 — with GitHub Actions Inactive
@kubbot
Copy link
Contributor

kubbot commented Sep 11, 2023

CLA Assistant Lite bot: 💕 Thank you for your contribution and please kindly read and sign our 🎯https://github.com/openim-sigs/cla/blob/main/README.md.
If you wish to sign the CRA, Please copy and comment on the following sentence:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@withchao withchao temporarily deployed to openim September 11, 2023 07:15 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 07:15 — with GitHub Actions Inactive
# Conflicts:
#	internal/push/push_to_client.go
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 10:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 11, 2023 11:04 — with GitHub Actions Inactive
@FGadvancer FGadvancer merged commit 3e1b147 into openimsdk:main Sep 11, 2023
@github-actions github-actions bot added this to the v3.1 milestone Sep 11, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: choose whether to push group messages offline based on the user's session option settings
4 participants