Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/msgtransfer: fix unreachable code issue #1078

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

charles-chenzz
Copy link
Contributor


🔍 What type of PR is this?

/kind bug

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

see #1009

🅰 Which issue(s) this PR fixes:

Fixes #1009

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2023
@kubbot
Copy link
Contributor

kubbot commented Sep 14, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@charles-chenzz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@charles-chenzz
Copy link
Contributor Author

recheck

openimbot added a commit to openim-sigs/cla that referenced this pull request Sep 14, 2023
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz charles-chenzz temporarily deployed to openim September 14, 2023 15:13 — with GitHub Actions Inactive
@charles-chenzz
Copy link
Contributor Author

@skiffer-git review when you get a chance. Thanks

@cubxxw cubxxw enabled auto-merge September 15, 2023 04:50
@cubxxw cubxxw added this pull request to the merge queue Sep 15, 2023
Merged via the queue into openimsdk:main with commit 7a3c3d7 Sep 15, 2023
@github-actions github-actions bot added this to the v3.1 milestone Sep 15, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: unreachable code in persistent msg handler
4 participants