Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add new “cyan” color function #31

Open
DerekNonGeneric opened this issue Feb 10, 2022 · 4 comments · Fixed by #124
Open

[feature request] add new “cyan” color function #31

DerekNonGeneric opened this issue Feb 10, 2022 · 4 comments · Fixed by #124

Comments

@DerekNonGeneric
Copy link
Member

The color “cyan” is preferable to “blue” in most cases especially since the default background color for the PowerShell app on Windows Server 2022 Standard (and many other previous version) is a very similar shade of blue making any foreground text color difficult to read as you can see in the following image.

image

Similar findings elsewhere:


I would prefer to call this function cyanify seeing as how the word “cyanize” already exists and seemingly has a completely different meaning.

Refs: https://www.merriam-webster.com/dictionary/cyanize

@ghost
Copy link

ghost commented Oct 21, 2022

Hi @DerekNonGeneric,

I have added this feature, and same as last time, excluded the generated intex.js file.
We have the same issue, that the CI code guidelines differ from the actual code style already in the repo.

Other than these, the feature works as expected

@DerekNonGeneric
Copy link
Member Author

Hey @dadolhay, good work! I see now what the issue is wrt to the CI code guidelines failing — i am going to see about getting that resolved right away (it doesn't look too difficult).

@ghost
Copy link

ghost commented Oct 21, 2022

@DerekNonGeneric
Sounds good!
I also suggest adding prettier to the project. With the appropriate config, it should handle the code formatting automatically and save some of the effort

@DerekNonGeneric
Copy link
Member Author

Just so that i don't forget about this, it was left undocumented and we still need to have that suggestion taken in this repo…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant