Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332917: failure_handler should execute gdb "info threads" command on linux #3251

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 29, 2025

I backport this for parity with 17.0.15-oracle


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332917 needs maintainer approval

Issue

  • JDK-8332917: failure_handler should execute gdb "info threads" command on linux (Enhancement - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3251/head:pull/3251
$ git checkout pull/3251

Update a local copy of the PR:
$ git checkout pull/3251
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3251

View PR using the GUI difftool:
$ git pr show -t 3251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3251.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332917: failure_handler should execute gdb "info threads" command on linux

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6453b75: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • b0c130b: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • d9fdc73: 8346908: Update JDK 17 javadoc man page
  • 2190b82: 8343378: Exceptions in javax/management DeadLockTest.java do not cause test failure
  • 16951de: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ec88c6a872a97cee1cde8844f5ee6834023a10c6 8332917: failure_handler should execute gdb "info threads" command on linux Jan 29, 2025
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 31, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Feb 5, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 5, 2025

Going to push as commit 2ebb6f5.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 3c6af86: 8329692: Add more details to FrameStateTest.java test instructions
  • 2fb96bf: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm
  • 0ef3fd0: 8325042: Remove unused JVMDITools test files
  • 5683021: 8320691: Timeout handler on Windows takes 2 hours to complete
  • 9f9655f: 8295176: some langtools test pollutes source tree
  • 6453b75: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • b0c130b: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • d9fdc73: 8346908: Update JDK 17 javadoc man page
  • 2190b82: 8343378: Exceptions in javax/management DeadLockTest.java do not cause test failure
  • 16951de: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 5, 2025
@openjdk openjdk bot closed this Feb 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2025
@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@GoeLin Pushed as commit 2ebb6f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant