Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240298: Array.prototype.pop, push, and reverse didn't call ToObject on their argument #12

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Dec 22, 2020

Array.prototype.pop, push, and reverse didn't call ToObject on their argument. I suggest reviewing with ignoring whitespace to lessen the impact of changed indentation because of removed try/catch blocks.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8240298: Array.prototype.pop, push, and reverse didn't call ToObject on their argument

Download

$ git fetch https://git.openjdk.java.net/nashorn pull/12/head:pull/12
$ git checkout pull/12

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2020

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 22, 2020
@szegedi szegedi changed the title 8240298: Array.prototype.pop, push, and reverse didn't call ToObject on their argument. 8240298: Array.prototype.pop, push, and reverse didn't call ToObject on their argument Dec 22, 2020
@szegedi szegedi merged commit 88396b5 into openjdk:main Dec 30, 2020
@szegedi szegedi deleted the array-to-object branch December 30, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant