8233195: Don't hoist block-scoped variables from dead code

[szegedi]

Fixes the bug where dead code removal would erroneously hoist block scoped variable declarations into the function scope; that should work for vars but not for lets and consts.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8233195: Don't hoist block-scoped variables from dead code

Reviewers

• Athijegannathan Sundararajan (@sundararajana - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/nashorn pull/6/head:pull/6
$ git checkout pull/6

[bridgekeeper]

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[sundararajana]

Looks good

[openjdk]

@szegedi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233195: Don't hoist block-scoped variables from dead code

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the main branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the main branch, type /integrate in a new comment.

[szegedi]

/integrate

[openjdk]

@szegedi Since your change was applied there have been 2 commits pushed to the main branch:

• 9ac6efe: 8244586: Opportunistic type evaluation should gracefully handle undefined lets and consts
• 9b87e5d: 8240299: A possible bug about Object.setPrototypeOf().

Your commit was automatically rebased without conflicts.

Pushed as commit cab0c85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.