Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240299: A possible bug about Object.setPrototypeOf(). #8

Closed
wants to merge 1 commit into from

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Dec 15, 2020

Object.setPrototypeOf should be a no-op on non-objects


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8240299: A possible bug about Object.setPrototypeOf().

Reviewers

Download

$ git fetch https://git.openjdk.java.net/nashorn pull/8/head:pull/8
$ git checkout pull/8

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2020

👋 Welcome back attila! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 15, 2020
@szegedi szegedi changed the title 8240299: Object.setPrototypeOf should be a no-op on non-objects 8240299: A possible bug about Object.setPrototypeOf(). Dec 16, 2020
@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@szegedi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240299: A possible bug about Object.setPrototypeOf().

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the main branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the main branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 17, 2020
@szegedi
Copy link
Collaborator Author

szegedi commented Dec 17, 2020

/integrate

@openjdk openjdk bot closed this Dec 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 17, 2020
@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@szegedi Pushed as commit 9b87e5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@szegedi szegedi deleted the fix-8240299 branch December 17, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants