Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ComplexRegions.jl: A Julia package for regions in the complex plane #1780

Closed
whedon opened this issue Oct 2, 2019 · 41 comments

Comments

@whedon
Copy link

whedon commented Oct 2, 2019

Submitting author: @tobydriscoll (Tobin Driscoll)
Repository: https://github.com/complexvariables/ComplexRegions.jl
Version: v0.1.0
Editor: @drvinceknight
Reviewers: @dlfivefifty, @dpsanders

Author instructions

Thanks for submitting your paper to JOSS @tobydriscoll. Currently, there isn't an JOSS editor assigned to your paper.

@tobydriscoll if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 2, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Oct 2, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon whedon added the Julia label Oct 2, 2019
@whedon
Copy link
Author

whedon commented Oct 2, 2019

PDF failed to compile for issue #1780 with the following error:

[WARNING] Could not convert image '/tmp/tex2pdf.242/3357d2f1f823ca2031ac9cc4fc4a70707debb275.svg': check that rsvg2pdf is in path.
rsvg-convert: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
Error producing PDF.
! LaTeX Error: Cannot determine size of graphic in /tmp/tex2pdf.242/3357d2f1f82
3ca2031ac9cc4fc4a70707debb275.svg (no BoundingBox).

See the LaTeX manual or LaTeX Companion for explanation.
Type H for immediate help.
...

l.361 ...d2f1f823ca2031ac9cc4fc4a70707debb275.svg}

Looks like we failed to compile the PDF

@kyleniemeyer
Copy link

Hi @drvinceknight, how do you feel about taking on another submission as editor?

@kyleniemeyer
Copy link

@arfon can papers use SVG images, or does this need to be converted to (e.g.) PDF?

@arfon
Copy link
Member

arfon commented Oct 2, 2019

@arfon can papers use SVG images, or does this need to be converted to (e.g.) PDF?

Unfortunately we don't currently support SVG. We can support PNG, PDF, JPEG, etc.

@kyleniemeyer
Copy link

@tobydriscoll could you replace the SVG image included in your article with a different format?

@drvinceknight
Copy link

Hi @drvinceknight, how do you feel about taking on another submission as editor?

Yup no problem.

@drvinceknight
Copy link

@whedon assign @drvinceknight as editor

@whedon
Copy link
Author

whedon commented Oct 3, 2019

OK, the editor is @drvinceknight

@drvinceknight
Copy link

@tobydriscoll I'll aim to get to this next week but in the meantime if you had any suggestions for reviewers please let me know.

@tobydriscoll
Copy link

I've pushed a change of the figure to PDF.

Possible reviewers are dlfivefifty, ajt60gaibb, daanhb. nakatsukasayuji.

@kyleniemeyer
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 3, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 3, 2019

@tobydriscoll
Copy link

Checked the proof and fixed typos in the references.

@kyleniemeyer
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 3, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 3, 2019

@drvinceknight
Copy link

@dlfivefifty, @ajt60gaibb, @daanhb would you be able to review this paper for JOSS? It describes a Julia package for working with complex regions.

If you have not reviewed for JOSS before, there are instructions here https://joss.readthedocs.io/en/latest/index.html and I'd be happy to answer any questions you might have.

Once we have 2 reviewers I will open a second issue where the review itself will take place.

One particular thing I'd appreciate your opinions on is the statement of need which I don't feel is made as clear as it could be in the paper

@dlfivefifty
Copy link

What’s the expected timeline?

@drvinceknight
Copy link

A few weeks would be great but if that's not possible let me know what you could possibly manage. (In my experience reviewing for JOSS takes less time and is more enjoyable than traditional publications - just FYI in case you haven't reviewed for JOSS before.)

@dlfivefifty
Copy link

I’m a bit busy but could probably do it within 3 weeks

@drvinceknight
Copy link

That would be great, I'll add you as a reviewer now @dlfivefifty.

@drvinceknight
Copy link

@whedon assign @dlfivefifty as reviewer

@whedon
Copy link
Author

whedon commented Oct 7, 2019

OK, the reviewer is @dlfivefifty

@ajt60gaibb
Copy link

@drvinceknight, I am afraid that I have too many refereeing jobs right now. I wouldn't be able to do it in a reasonable time frame. This process looks interesting, though.

@drvinceknight
Copy link

No problem @ajt60gaibb thanks for responding. 👍

@drvinceknight
Copy link

Hi @vchuravy I know this doesn't fit immediately within your area of expertise but would you be willing to review this paper for JOSS?

@ChrisRackauckas, @Datseris would you be able to review this paper for JOSS?

@daanhb
Copy link

daanhb commented Oct 11, 2019

Hi @drvinceknight, if you're looking for more reviewers, I can still chime in - though I'll probably have a similar point of view as @dlfivefifty (being co-authors of the DomainSets.jl package)

@Datseris
Copy link

Hello, thank you for the invitation, but I have to kindly decline reviewing this, as I believe it does not fall into my area of expertise.

@ChrisRackauckas
Copy link

I am way oversubscribed until Spring. If you're still looking for reviews then, feel free to ping me.

@vchuravy
Copy link

@dpsanders might be a better fit than me.

@drvinceknight
Copy link

Hello, thank you for the invitation, but I have to kindly decline reviewing this, as I believe it does not fall into my area of expertise.

I am way oversubscribed until Spring. If you're still looking for reviews then, feel free to ping me.

I understand @ChrisRackauckas and @Datseris , thank you for responding.

@dpsanders might be a better fit than me.

Thank you @vchuravy, @dpsanders would you be able to review this paper please?

Hi @drvinceknight, if you're looking for more reviewers, I can still chime in - though I'll probably have a similar point of view as @dlfivefifty (being co-authors of the DomainSets.jl package)

Thank you @daanhb, I'm going to wait a day or so to see if @dpsanders responds positively to gain a bit more variety of review but if not and you're still able I would be very grateful!

@dpsanders
Copy link

Yes I am happy to review but have a bit of a backlog right now.

@drvinceknight
Copy link

Thanks @dpsanders I'll add you as a reviewer and if your backlog gets too much let me know.

@drvinceknight
Copy link

@whedon add @dpsanders as reviewer

@whedon
Copy link
Author

whedon commented Oct 15, 2019

OK, @dpsanders is now a reviewer

@drvinceknight
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Oct 15, 2019

OK, I've started the review over in #1811. Feel free to close this issue now!

@drvinceknight
Copy link

@dpsanders and @dlfivefifty the review will take place on #1811, please let me know if you have any questions about the process and thank you again for agreeing to take this on. It's a vital part of the process.

@daanhb thank you very much for offering to review, it's truly appreciated and hopefully you won't mind me calling on you in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests