-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: ComplexRegions.jl: A Julia package for regions in the complex plane #1780
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
|
PDF failed to compile for issue #1780 with the following error: [WARNING] Could not convert image '/tmp/tex2pdf.242/3357d2f1f823ca2031ac9cc4fc4a70707debb275.svg': check that rsvg2pdf is in path. See the LaTeX manual or LaTeX Companion for explanation. l.361 ...d2f1f823ca2031ac9cc4fc4a70707debb275.svg} Looks like we failed to compile the PDF |
Hi @drvinceknight, how do you feel about taking on another submission as editor? |
@arfon can papers use SVG images, or does this need to be converted to (e.g.) PDF? |
Unfortunately we don't currently support SVG. We can support PNG, PDF, JPEG, etc. |
@tobydriscoll could you replace the SVG image included in your article with a different format? |
Yup no problem. |
@whedon assign @drvinceknight as editor |
OK, the editor is @drvinceknight |
@tobydriscoll I'll aim to get to this next week but in the meantime if you had any suggestions for reviewers please let me know. |
I've pushed a change of the figure to PDF. Possible reviewers are dlfivefifty, ajt60gaibb, daanhb. nakatsukasayuji. |
@whedon generate pdf |
|
Checked the proof and fixed typos in the references. |
@whedon generate pdf |
|
@dlfivefifty, @ajt60gaibb, @daanhb would you be able to review this paper for JOSS? It describes a Julia package for working with complex regions. If you have not reviewed for JOSS before, there are instructions here https://joss.readthedocs.io/en/latest/index.html and I'd be happy to answer any questions you might have. Once we have 2 reviewers I will open a second issue where the review itself will take place. One particular thing I'd appreciate your opinions on is the statement of need which I don't feel is made as clear as it could be in the paper |
What’s the expected timeline? |
A few weeks would be great but if that's not possible let me know what you could possibly manage. (In my experience reviewing for JOSS takes less time and is more enjoyable than traditional publications - just FYI in case you haven't reviewed for JOSS before.) |
I’m a bit busy but could probably do it within 3 weeks |
That would be great, I'll add you as a reviewer now @dlfivefifty. |
@whedon assign @dlfivefifty as reviewer |
OK, the reviewer is @dlfivefifty |
@drvinceknight, I am afraid that I have too many refereeing jobs right now. I wouldn't be able to do it in a reasonable time frame. This process looks interesting, though. |
No problem @ajt60gaibb thanks for responding. 👍 |
Hi @vchuravy I know this doesn't fit immediately within your area of expertise but would you be willing to review this paper for JOSS? @ChrisRackauckas, @Datseris would you be able to review this paper for JOSS? |
Hi @drvinceknight, if you're looking for more reviewers, I can still chime in - though I'll probably have a similar point of view as @dlfivefifty (being co-authors of the DomainSets.jl package) |
Hello, thank you for the invitation, but I have to kindly decline reviewing this, as I believe it does not fall into my area of expertise. |
I am way oversubscribed until Spring. If you're still looking for reviews then, feel free to ping me. |
@dpsanders might be a better fit than me. |
I understand @ChrisRackauckas and @Datseris , thank you for responding.
Thank you @vchuravy, @dpsanders would you be able to review this paper please?
Thank you @daanhb, I'm going to wait a day or so to see if @dpsanders responds positively to gain a bit more variety of review but if not and you're still able I would be very grateful! |
Yes I am happy to review but have a bit of a backlog right now. |
Thanks @dpsanders I'll add you as a reviewer and if your backlog gets too much let me know. |
@whedon add @dpsanders as reviewer |
OK, @dpsanders is now a reviewer |
@whedon start review |
OK, I've started the review over in #1811. Feel free to close this issue now! |
@dpsanders and @dlfivefifty the review will take place on #1811, please let me know if you have any questions about the process and thank you again for agreeing to take this on. It's a vital part of the process. @daanhb thank you very much for offering to review, it's truly appreciated and hopefully you won't mind me calling on you in the future. |
Submitting author: @tobydriscoll (Tobin Driscoll)
Repository: https://github.com/complexvariables/ComplexRegions.jl
Version: v0.1.0
Editor: @drvinceknight
Reviewers: @dlfivefifty, @dpsanders
Author instructions
Thanks for submitting your paper to JOSS @tobydriscoll. Currently, there isn't an JOSS editor assigned to your paper.
@tobydriscoll if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: