-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PlanktonIndividuals.jl: A GPU supported individual-based phytoplankton life cycle model. #4207
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
@navidcy and @Datseris thanks again for agreeing to review this submission to JOSS. We've just switched over from whedon to the new editorialbot, and the review process has changed subtly. Instead of your checklist being at the top of this issue, you can generate your own checklist with the command We're starting this review before I've found a 3rd reviewer out of respect for @navidcy's availability in late March, so as a heads up to @zhenwu0728 and co-authors, I will still be reaching out to and hopefully adding another reviewer here. |
Review checklist for @DatserisConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot add @BrodiePearson as reviewer |
@BrodiePearson added to the reviewers list! |
Review checklist for @BrodiePearsonConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello @elbeejay , I would like to submit my review: SummaryPlanktonIndividuals.jl is a Julia package that simulates the lifecycle and transport of plankton in oceanic currents. It has strong performance capabilities utilizing GPU infrastructure. The paper makes a clear case supporting the need for the package. The paper and authors satisfy the official checklist of JOSS. As far as I can tell, the documentation of the package is very good. It includes documentation strings, examples, and clearly states the actual physics used in the models via stating actual equations, something that (unfortunately) is missing from many packages. I was able to install the software and run their 0D example without problems. All in all, I would recommend publication, however, there are some points I would strongly recommend the authors to consider, and address satisfactorily. Additions I would recommend
Minor technical details
|
Thank you for the thorough review @Datseris! I agree with your comments about the documentation being quite comprehensive and clear, and your suggestions to @zhenwu0728 and co-authors seem reasonable to me. |
@navidcy I was going to ping you so that hopefully this review doesn't slip through the cracks before you are unavailable - the new JOSS procedure requires you to create your own reviewer checklist with the command Thanks! |
Thank you for your comments and suggestions @Datseris! @gaelforget and I are working on it. |
Thanks. I haven't forgotten about this. |
Hello all, I'm going to ask our editorial bot to send out reminders to @navidcy and @BrodiePearson over the next few weeks just to hopefully keep things moving along with this review. @zhenwu0728 please feel free to provide an update in this thread when you feel you have addressed @Datseris comments to ensure those outstanding review checklist items can be crossed off. Thanks all, |
Reminder set for @navidcy in one week |
@editorialbot remind @BrodiePearson in two weeks |
Reminder set for @BrodiePearson in two weeks |
@editorialbot remind @navidcy in seven days |
Reminder set for @navidcy in seven days |
👋 @navidcy, please update us on how your review is going (this is an automated reminder). |
1 similar comment
👋 @navidcy, please update us on how your review is going (this is an automated reminder). |
I’m really sorry. I’m down with covid… :( |
@elbeejay Here is my review: Overall this looks like a useful package with good documentation. I particularly like that the package has both stand-alone utility (lab experiments) and an ability to integrate with other software packages used to simulate ocean flows (e.g., Oceananigans). I only have a few very small comments to add beyond the previous review Review Comments
|
@editorialbot set v0.5.1 as version |
Done! version is now v0.5.1 |
@editorialbot set 10.5281/zenodo.6507001 as archive |
Done! Archive is now 10.5281/zenodo.6507001 |
@editorialbot generate pdf |
Hi @elbeejay, thanks for the clarification. Now the citation should be good, no more nested parentheses. |
@editorialbot check references |
|
@zhenwu0728 looks great. Thanks again to @Datseris and @BrodiePearson for providing constructive reviews. At this time I will be recommending we accept and publish this paper in JOSS. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#3184 If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3184, then you can now move forward with accepting the submission by compiling again with the command |
Hi @zhenwu0728, I'm the AEIC on duty doing some final checks before publishing. In your article, could you add commas after instances of "e.g.", and remove "etc." from parenthetical statements that start with "e.g."? Also, It looks like there is actually a JOSS article on Agents.jl you should probably cite (https://doi.org/10.21105/joss.01611), perhaps in addition to the newer article you do cite. |
@editorialbot generate pdf |
Thanks @kyleniemeyer! I've added the citation you mentioned and also changed the "e.g.," |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thanks a lot! @elbeejay @Datseris @BrodiePearson @kyleniemeyer |
Congratulations @zhenwu0728 on your article's publication in JOSS! Many thanks to @Datseris and @BrodiePearson for reviewing this, and @elbeejay for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @zhenwu0728 (Zhen Wu)
Repository: https://github.com/JuliaOcean/PlanktonIndividuals.jl
Branch with paper.md (empty if default branch):
Version: v0.5.1
Editor: @elbeejay
Reviewers: @Datseris, @BrodiePearson
Archive: 10.5281/zenodo.6507001
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@navidcy & @Datseris, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @elbeejay know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @Datseris
📝 Checklist for @BrodiePearson
The text was updated successfully, but these errors were encountered: