Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SyntheticEddyMethod.jl: A Julia package for the creation of inlet flow conditions for LES #5416

Closed
editorialbot opened this issue Apr 27, 2023 · 33 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 27, 2023

Submitting author: @carlodev (Carlo Brunelli)
Repository: https://github.com/carlodev/SyntheticEddyMethod.jl
Branch with paper.md (empty if default branch): JossSub
Version: v0.4.1
Editor: @philipcardiff
Reviewers: @atzberg, @akshaysridhar
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8a5b8b6eec19373a7eb3d154b4d0eed6"><img src="https://joss.theoj.org/papers/8a5b8b6eec19373a7eb3d154b4d0eed6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8a5b8b6eec19373a7eb3d154b4d0eed6/status.svg)](https://joss.theoj.org/papers/8a5b8b6eec19373a7eb3d154b4d0eed6)

Author instructions

Thanks for submitting your paper to JOSS @carlodev. Currently, there isn't a JOSS editor assigned to your paper.

@carlodev if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Apr 27, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.02 s (1713.3 files/s, 186930.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TOML                             3            226              1           1053
Julia                           12            224             97            717
Markdown                         7            183              0            493
YAML                             5              3              6            107
TeX                              1              3              0             50
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            29            639            104           2421
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ijheatfluidflow.2006.02.006 is OK
- 10.1007/s10494-013-9488-2 is OK

MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing

INVALID DOIs

- https://doi.org/10.1016/j.ijheatmasstransfer.2019.02.061 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 654

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@carlodev
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@carlodev
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @carlodev, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@carlodev
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.1016/j.ijheatfluidflow.2006.02.006 is OK
- 10.1007/s10494-013-9488-2 is OK
- 10.1016/j.ijheatmasstransfer.2019.02.061 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kyleniemeyer
Copy link

Hi @carlodev, sorry for the radio silence after starting the pre-review issue. I'm in the process of finding an editor for your submission—unfortunately editor availability in this area is low right now.

@kyleniemeyer
Copy link

@editorialbot invite @philipcardiff as editor

Hi @philipcardiff, could you handle this submission?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@philipcardiff
Copy link

@editorialbot invite @philipcardiff as editor

Hi @philipcardiff, could you handle this submission?

Yes, I can @kyleniemeyer

@philipcardiff
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @philipcardiff is now the editor

@philipcardiff
Copy link

HI @carlodev, I proposed some minor English edits at carlodev/SyntheticEddyMethod.jl#18 and carlodev/SyntheticEddyMethod.jl#19.

@philipcardiff
Copy link

philipcardiff commented Jun 8, 2023

Hello @atzberg, would you be interested in reviewing this paper/code?

@carlodev
Copy link

carlodev commented Jun 8, 2023

@philipcardiff Thank you so much for agreeing to review and point out the typos

@atzberg
Copy link

atzberg commented Jun 8, 2023 via email

@philipcardiff
Copy link

Hi Philip, Sure, I would be happy to review. -- Paul

Great, thank you, Paul.

Here are the review criteria and review checklist.

I will find at least one other reviewer.

@philipcardiff
Copy link

@editorialbot add @atzberg as reviewer

@editorialbot
Copy link
Collaborator Author

@atzberg added to the reviewers list!

@philipcardiff
Copy link

philipcardiff commented Jun 8, 2023

Hello @ali-ramadhan, would you review this submission for JOSS? The submission under consideration is SyntheticEddyMethod.jl: A Julia package for the creation of inlet flow conditions for LES (https://github.com/carlodev/SyntheticEddyMethod.jl).

If you are unfamiliar with JOSS, the review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can have a look at our review criteria and review checklist to get an idea of what is expected.

Philip

@atzberg
Copy link

atzberg commented Jun 14, 2023

@editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Checklists can only be created once the review has started in the review issue

@philipcardiff
Copy link

Hi @carlodev , do you have any reviewer suggestions?

@philipcardiff
Copy link

@editorialbot add @akshaysridhar as reviewer

@editorialbot
Copy link
Collaborator Author

@akshaysridhar added to the reviewers list!

@philipcardiff
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5565.

@philipcardiff
Copy link

Hi all, we can continue our coversation in the review issue #5565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants