-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: LobsterPy: A package to automatically analyze LOBSTER runs #6286
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @berquistConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @srmnitcConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@RMeli I have now finished my review. Lobsterpy is a well-designed, and maintained package which I believe would be useful for the community. It has already been employed in a number of studies. The code and documentation are in very good shape, and it was really easy to get started with the tool. I had only some minor issues, which @JaGeo and team fixed very quickly. There are only minor corrections to the paper remaining. Overall, I recommend the publication of this package. Thanks @RMeli for inviting me to review, and @JaGeo for this nice software. |
Thank you very much, @srmnitc (I mixed up the handles first, sorry!) |
Thank you @srmnitc for all the hard work!
I've noticed it, thanks @JaGeo for the very prompt replies to the reviewer queries and comments.
Did you suggest these minor corrections anywhere? I only see JaGeo/LobsterPy#225, are you referring just to those two suggestions? |
Yes, correct, just the two. |
@editorialbot generate pdf |
|
We (@naik-aakash and I) have addressed the comments in JaGeo/LobsterPy#226, @RMeli . |
@editorialbot generate pdf |
@editorialbot generate pdf |
Hello @berquist, how are you? How is the review coming along? Please let me know if you have any questions or blockers. |
@editorialbot set https://doi.org/10.5281/zenodo.10713348 as archive |
Done! archive is now 10.5281/zenodo.10713348 |
@editorialbot set v0.3.8 as version |
Done! version is now v0.3.8 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5055, then you can now move forward with accepting the submission by compiling again with the command |
@RMeli Thank you so much! And thanks also for the great review experience! 😀 |
@RMeli thanks for editing this one. It looks like perhaps |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@JaGeo As AEiC on this track I will now help process the final steps to help with acceptance in JOSS. I have just checked the paper, this review, your repository, and the archive link. Most seems in order. I'd only ask you to please ensure that the license listed on the archive link matches your software license. Can you edit this please? |
@Kevin-Mattheus-Moerman Thank you. I have edited the repo metadata and changed the license to the 'BSD 3-Clause "New" or "Revised" License" |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thank you very much, @Kevin-Mattheus-Moerman . And, of course, thank you so mich, @srmnitc and @berquist for your reviews, as well! |
Congratulations @JaGeo! @Kevin-Mattheus-Moerman this was my very fist time editing, thank you for double checking everything carefully and suggesting the "Post-Review Checklist" (I used the one on the Editorial Guide, but clearly slipped on the last point). |
@Kevin-Mattheus-Moerman can I close the issue once the paper is accepted? (I expected the bot to close it automatically, but I just noticed that it's still open.) |
I'll do that shortly after some thanks/congratulations messages. Thanks |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @JaGeo (Janine George)
Repository: https://github.com/JaGeo/LobsterPy
Branch with paper.md (empty if default branch):
Version: v0.3.8
Editor: @RMeli
Reviewers: @berquist, @srmnitc
Archive: 10.5281/zenodo.10713348
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@berquist & @srmnitc, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @RMeli know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @berquist
📝 Checklist for @srmnitc
The text was updated successfully, but these errors were encountered: