-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: An Introduction to prismAId
: Open-Source and Open Science AI for Advancing Information Extraction in Systematic Reviews
#7616
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
👋 @ricboer0, @philip928lin and @jhculb - This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #7616 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @philip928linConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @jhculbConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @ricboer0, I'm getting a 404 on the github.io documentation link in the readme: https://open-and-sustainable.github.io/prismAId/ Is this just me? @philip928lin |
Hi @ricboer0, Your paper may be improved with a brief survey of past and current academic information extraction tools, as at the moment the state of the field section of the paper feels lacking. Perhaps LISC https://github.com/lisc-tools/lisc ? |
@jhculb I encountered same issue as you. Multiple hyperlinks in the readme have same issue. @ricboer0 please double check the links. |
Hi @ricboer0, The online configurator did not output the correct format Error loading project configuration: toml: line 27 (last key "project.llm.1.temperature"): incompatible types: TOML value has type string; destination has type float Namely, the following lines in TOML file
should be
Also, if the online Review Configurator can automatically format the path string for users, it can eliminate the potential errors as shown below.
|
Hi @ricboer0, I also tried to play with the Zotero Integration. I appreciate this feature. However, more detailed steps and expected outputs can be provided in the documentation to ease usage.
@ricboer0, I would appreciate more detailed instructions and examples on the Zotero integration feature. Also, another side note, when I executed the Python script in the IDE like Spyder, it restarted a new kernel in the middle of the process every time. However, this may be due to the IDE's internal issue. I can successfully run the Python script when directly called from the command line. |
Hi @jhculb and @philip928lin, I am working to double check and fix links to documentation website |
Hi @jhculb, However, following guidelines from the editor @crvernon I significantly reduced the length of the paper and removed that section (among others). You can read that 'introduction' section in the preprint that corresponds to the first submission of this paper at https://doi.org/10.31222/osf.io/wh8qn. I am open to any suggestion. In this shorter version of the paper I already reference the extended introduction accessible in the preprint for a more complete description of alternative approaches but if this is not enough I would be happy to bring that removed section back into the paper. It is just a matter of space constraints, if they matter. |
Hi @philip928lin, |
Hi @philip928lin, On issue .3: since you can find the Zotero manuscripts on your machine, it means that the Zotero integration is properly configured and actually working: it connects to the API, it finds the collection, downloads the pdfs and 'tries' the conversion to .txt. |
Hi @jhculb and @philip928lin, Please verify if the changes address the comments you raised. Additionally, could you let me know if I can extend the paper to include a review of the state of the field? This would help to clearly highlight the novelty of this tool, but I believe it cannot be added at the expense of other sections in the paper, as they are all at least as essential. |
Hi @ricboer0, I will defer to the editor on this (@crvernon - your thoughts?), but I understand that the focus for JOSS' State of the field section is the availability of similar software and the distinction to your tool. From the review checklist; "State of the field: Do the authors describe how this software compares to other commonly-used packages?" Having a quick look at your preprint I see a interesting review of the field but no explicit software cited, which may be the reason @crvernon asked for it to be condensed. I personally would recommend a short review of popular or distubguished software packages / applications providing similar functionality be included. Otherwise a fine paper I believe :) |
@editorialbot generate pdf |
Concerning the length of the paper and the statement of need:
I think this is a reasonable request. In JOSS we want to keep the paper as succinct as possible and encourage the procedural and in-depth descriptive content to be placed in the software's documentation for lasting benefit that will hopefully be improved as the software evolves. This makes the JOSS paper for powerful too, since it will not be filled with content that may be quickly outdated as versions of the software change - instead, with a focus on why this software is needed and why it is being introduced as an open-source community research software. On this note, it is good to cite what is comparable and the value that you believe that your software is adding. JOSS does not require uniqueness, but the hope is that this transparency in the statement of need section will give users context to quickly decide if the proposed software is one that may benefit their own research. Thanks! |
@editorialbot generate pdf |
@crvernon, @jhculb, and @philip928lin , Please let me know if there are any other points where the paper can be improved. |
@editorialbot generate pdf |
Submitting author: @ricboer0 (Riccardo Boero)
Repository: https://github.com/open-and-sustainable/prismaid
Branch with paper.md (empty if default branch): joss-submission
Version: v0.6.4
Editor: @crvernon
Reviewers: @philip928lin, @jhculb
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@philip928lin & @jhculb, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @philip928lin
📝 Checklist for @jhculb
The text was updated successfully, but these errors were encountered: