Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(members): add evenstensberg #1212

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore(members): add evenstensberg #1212

merged 1 commit into from
Nov 29, 2023

Conversation

evenstensberg
Copy link
Member

No description provided.

@evenstensberg evenstensberg requested a review from a team as a code owner November 29, 2023 18:31
@evenstensberg evenstensberg merged commit 71cf867 into openjs-foundation:main Nov 29, 2023
2 checks passed
@evenstensberg evenstensberg deleted the add-even branch November 29, 2023 18:50
@ljharb
Copy link
Member

ljharb commented Nov 29, 2023

@evenstensberg for future reference, governance is that a PR must be open for 72 hours before merging.

@evenstensberg
Copy link
Member Author

Gotcha

@joesepi
Copy link
Member

joesepi commented Nov 29, 2023

@evenstensberg there are a number of issues with this PR having been merged:

  • the 72hr requirement unless fast tracked like @ljharb said above
  • there should be at least two approvers on a PR before merging
  • the member list is alphabetical and this PR breaks that

@evenstensberg
Copy link
Member Author

So sorry @joesepi . You can revert this PR and I'll submit a new one. Again, sorry!

@joesepi
Copy link
Member

joesepi commented Nov 29, 2023

So sorry @joesepi . You can revert this PR and I'll submit a new one. Again, sorry!

@evenstensberg -- Its not really a big deal at all, so no worries. I just wanted to share all that was at issue for awareness.

I'll just fix the alphabetizing in a new PR and fast track it. :)

joesepi added a commit that referenced this pull request Nov 29, 2023
A recent PR (#1212) had a couple issues that I'm fixing here.

Signed-off-by: Joe Sepi <[email protected]>
joesepi added a commit that referenced this pull request Nov 30, 2023
A recent PR (#1212) had a couple issues that I'm fixing here.

Signed-off-by: Joe Sepi <[email protected]>
bensternthal pushed a commit to bensternthal/cross-project-council that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants