Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preNormal hook for Advanced StatefulSet #1858

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Dec 13, 2024

Ⅰ. Describe what this PR does

rebase PR #1277
including changes in PR #1141

fixes #1213

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.36%. Comparing base (0d0031a) to head (6cf197b).
Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/statefulset/stateful_set_control.go 71.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
+ Coverage   47.91%   50.36%   +2.45%     
==========================================
  Files         162      193      +31     
  Lines       23491    24906    +1415     
==========================================
+ Hits        11256    12545    +1289     
- Misses      11014    11070      +56     
- Partials     1221     1291      +70     
Flag Coverage Δ
unittests 50.36% <76.92%> (+2.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1 ABNER-1 requested a review from veophi December 18, 2024 03:49
Signed-off-by: mingzhou.swx <[email protected]>
pkg/util/tools.go Outdated Show resolved Hide resolved
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@furykerry furykerry merged commit aeb7f19 into openkruise:master Dec 25, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add lifecycle preNormal for Advanced StatefulSet
2 participants