Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using graph node type #13

Merged
merged 4 commits into from
Jan 12, 2022
Merged

chore: using graph node type #13

merged 4 commits into from
Jan 12, 2022

Conversation

fforbeck
Copy link
Contributor

@fforbeck fforbeck commented Jan 11, 2022

🥳 Adds

  • GRAPH_NODE_TYPE env var to indicate the type of the node that we will be deploying the subgraph to.
  • additional env var checks depending on node type deployment

⛔️ Removes

  • NETWORK env var

@fforbeck fforbeck requested a review from jdville03 January 11, 2022 16:35
@fforbeck fforbeck changed the title chore: using graph node type [WIP] chore: using graph node type Jan 11, 2022
@fforbeck
Copy link
Contributor Author

fforbeck commented Jan 11, 2022

@jdville03 While I was testing the subgraph deployment for the new tutorial version I noticed we don't really use the networks, they work as a flag to indicate which graph node we will be deploying to. I refactored that to use a specific node type variable, since the network doesn't really matter as long as we set it correctly in the subgraph attribute. Also, if we use other networks such as: polygon, polygontest, harmony, harmonytest, xdai, etc we would need to update the script every time a new network is added.
wdyt about this approach? am I missing anything here?
thanks

@jdville03 jdville03 force-pushed the patch/deploy-script branch from 2f46978 to 7259522 Compare January 12, 2022 00:30
@jdville03 jdville03 changed the title [WIP] chore: using graph node type chore: using graph node type Jan 12, 2022
@jdville03 jdville03 marked this pull request as ready for review January 12, 2022 00:31
Copy link
Member

@jdville03 jdville03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting this. I updated some of the documentation and added more required env var checks depending on the graph node type.

@jdville03 jdville03 merged commit 1f739de into main Jan 12, 2022
@jdville03 jdville03 deleted the patch/deploy-script branch January 12, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants