Fix bug with reader role #4380

src/core/models.py

@@ -543,6 +543,9 @@ def is_preprint_editor(self, request):
 
         return False
 
+    def is_reader(self, request):
+        return self.check_role(request.journal, 'reader', staff_override=False)
+
     def snapshot_self(self, article, force_update=True):
         frozen_dict = {
             'name_prefix': self.name_prefix,

src/core/views.py

@@ -546,6 +546,7 @@ def edit_profile(request):
         'staff_group_membership_form': staff_group_membership_form,
         'user_to_edit': user,
         'send_reader_notifications': send_reader_notifications,
+        'user_is_reader': user.is_reader(request),
     }
 
     return render(request, template, context)

src/templates/admin/core/accounts/edit_profile.html

@@ -63,7 +63,7 @@ <h2>{% trans "Register for Article Notifications" %}</h2>
               published in this journal.
             {% endblocktrans %}</p>
             {% csrf_token %}
-            {% if reader %}
+            {% if user_is_reader %}
               <button name="unsubscribe" class="button secondary">
                 {% trans "Unsubscribe from Article Notifications" %}
               </button>