Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotSupportedError in decision helper -> share on mysql #3849

Closed
everreau opened this issue Dec 18, 2023 · 1 comment
Closed

NotSupportedError in decision helper -> share on mysql #3849

everreau opened this issue Dec 18, 2023 · 1 comment
Assignees
@ajrbyers
Labels
bug Something's not working

Comments

@everreau
Copy link
Contributor

Describe the bug
When a users select "Share" from the decision helper page we get "NotSupportedError - DISTINCT ON fields is not supported by this database backend". We are running mysql.

https://github.com/eScholarship/janeway/blob/master/src/review/views.py#L2847

Janeway version
1.5.1-RC3

To Reproduce
Steps to reproduce the behavior:

  1. Go to an article in review
  2. Click on "Make a decision"
  3. Click on "Share reviews"
  4. See error (if you're using mysql)

Expected behavior
No error.
@everreau everreau added the bug Something's not working label Dec 18, 2023
@github-project-automation github-project-automation bot moved this to 📋 Todo in v1.5.1 Archer Jan 9, 2024
@ajrbyers ajrbyers self-assigned this Jan 9, 2024
ajrbyers added a commit that referenced this issue Jan 9, 2024
@ajrbyers
#3849 adds a utility function to return a list of reviews based on di…
4ac73e6 
…stinct reviewers.
@ajrbyers ajrbyers mentioned this issue Jan 9, 2024
Closed
@ajrbyers ajrbyers moved this from 📋 Todo to 📝 PR Submitted in v1.5.1 Archer Jan 9, 2024
ajrbyers added a commit that referenced this issue Jan 9, 2024
@ajrbyers
#3849 adds a utility function to return a list of reviews based on di…
18fe178 
…stinct reviewers.
ajrbyers added a commit that referenced this issue Jan 9, 2024
@ajrbyers
#3849 added a database agnostic way to get a list of reviews based on…
75c7b9f 
… distinct reviewers
@ajrbyers ajrbyers mentioned this issue Jan 9, 2024
Merged
mauromsl added a commit that referenced this issue Jan 24, 2024
@mauromsl
#3849: refactor for performance
6cc6914
mauromsl pushed a commit that referenced this issue Jan 24, 2024
@ajrbyers @mauromsl
#3849 added a database agnostic way to get a list of reviews based on…
15fc5f8 
… distinct reviewers
mauromsl added a commit that referenced this issue Jan 24, 2024
@mauromsl
#3849: refactor for performance
c2d48e9
@mauromsl
Copy link
Member

Closed by #3876 on b_1_5_1

@github-project-automation github-project-automation bot moved this from 📝 PR Submitted to ✅ Done in v1.5.1 Archer Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

Labels
bug Something's not working
Projects
No open projects
v1.5.1 Archer
Status: ✅ Done
Milestone
No milestone
3 participants
@everreau @ajrbyers @mauromsl