Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches starting with a blank space result in practically everything published #3897

Closed
alainna opened this issue Jan 17, 2024 · 2 comments · Fixed by #4067
Closed

Searches starting with a blank space result in practically everything published #3897

alainna opened this issue Jan 17, 2024 · 2 comments · Fixed by #4067
Assignees
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. size XS Extra small

Comments

@alainna
Copy link
Contributor

alainna commented Jan 17, 2024

Describe the bug
When a search of Janeway begins with a blank space, the resulting hit count is unexpectedly high, seemingly almost everything published.

Janeway version
1.5.1 RC1 (Repository confirmed, possibly journals also)

To Reproduce
Steps to reproduce the behavior:

  1. Search Janeway for a published article title, starting the search with a space. Note the hit count. For example, this search of EarthArXiv for "High-resolution methane mapping with the EnMAP" begins with a space and results in 3933 hits: https://eartharxiv.org/repository/search/%20High-resolution%20methane%20mapping%20with%20the%20EnMAP/(at the time, there were 4335 items published)
  2. Compare remove the starting space and compare. For example, this search results in 3933 hits: https://eartharxiv.org/repository/search/High-resolution%20methane%20mapping%20with%20the%20EnMAP/ (note: adding a trailing space at the end does not change the result count.)

Expected behavior
The initial space would be ignored.

Screenshot
attachment

@alainna alainna added the bug Something's not working label Jan 17, 2024
@ajrbyers
Copy link
Member

To be fair… most titles and abstracts contain spaces… but yes we should strip white space 🤣

@alainna
Copy link
Contributor Author

alainna commented Jan 17, 2024

Yeah, the search is working too well in this case! 😂

@ajrbyers ajrbyers added size XS Extra small dev-ready This issue has been refined and is ready for development. labels Mar 14, 2024
ajrbyers added a commit that referenced this issue Mar 28, 2024
@ajrbyers ajrbyers self-assigned this Mar 28, 2024
joemull pushed a commit that referenced this issue Apr 17, 2024
ajrbyers added a commit that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. size XS Extra small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants