Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Reviews does not work due to incorrect text field widget #4086

Closed
joemull opened this issue Apr 9, 2024 · 0 comments · Fixed by #4116
Closed

Share Reviews does not work due to incorrect text field widget #4086

joemull opened this issue Apr 9, 2024 · 0 comments · Fixed by #4116
Assignees
@ajrbyers
Labels
bug Something's not working priority-high High priority size S Small

Comments

@joemull
Copy link
Member

joemull commented Apr 9, 2024

I believe this widget needs to be changed to TinyMCE:

https://github.com/BirkbeckCTP/janeway/blob/e030e06bcb2c42d51009cb659c036658e2a038ed/src/review/forms.py#L451
@joemull joemull added the bug Something's not working label Apr 9, 2024
@joemull joemull added this to v1.5.2 Apr 9, 2024
@joemull joemull moved this to Todo in v1.5.2 Apr 9, 2024
@ajrbyers ajrbyers self-assigned this Apr 17, 2024
@ajrbyers ajrbyers removed this from v1.5.2 Apr 22, 2024
@ajrbyers ajrbyers added priority-high High priority size S Small labels Apr 24, 2024
@ajrbyers ajrbyers assigned ajrbyers and unassigned ajrbyers Apr 25, 2024
ajrbyers added a commit that referenced this issue Apr 25, 2024
@ajrbyers
#4086 swaps ShareReviewsForm widgets over to TinyMCE.
3a1d001
@ajrbyers ajrbyers mentioned this issue Apr 25, 2024
Merged
mauromsl pushed a commit that referenced this issue Apr 25, 2024
@ajrbyers @mauromsl
#4086 swaps ShareReviewsForm widgets over to TinyMCE.
fd6fbbc
ajrbyers added a commit that referenced this issue Apr 30, 2024
@ajrbyers
#4086 swaps ShareReviewsForm widgets over to TinyMCE.
bbae7a1
joemull pushed a commit that referenced this issue Apr 30, 2024
@ajrbyers @joemull
#4086 swaps ShareReviewsForm widgets over to TinyMCE.
9132f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajrbyers ajrbyers

Labels
bug Something's not working priority-high High priority size S Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a bug that stopped the Share Reviews page from loading properly. openlibhums/janeway
2 participants
@ajrbyers @joemull