Revision Request Notes Not Saving as of 1.5.1

[justingonder]

Describe the bug
When editors enter text into the Editor Note field on the Request Revisions page:

The text of the note is not present in the email sent to the author:

Nor on the Revision Request Details page:

Janeway version
Our users began noticing this data loss when we rolled out 1.5.1 RC6
Have confirmed the behavior is the same in 1.5.1 final as well.

[joemull]

Thanks @justingonder. I'm looking into this now.

[joemull]

This is happening because JQTE is still being loaded into the template, which modifies the HTML in a way that is unrecognizable to the TinyMCE Django form that looks for the field on save.

https://github.com/BirkbeckCTP/janeway/blob/v1.5.1/src/templates/admin/review/revision/request_revisions.html#L73

It can be patched by removing line 73.

[joemull]

One more update: I've reviewed all the templates that could theoretically be affected by this and narrowed it down to just one additional problem template:

src/templates/admin/review/draft_decision.html

You don't use the Draft Decisions feature at CDL, do you? If not, this shouldn't affect you.

So, what you can do for the time being in production is switch the branch 4088-jqte-hotfix, which is one commit ahead of the pinned v1.5.1. All it does is drop the offending line that breaks the Request Revisions form.

In terms of Janeway versions and pins, we have already pinned the final version of 1.5.1, and haven't yet sped up our semantic versioning to make better use of the small numbers, so we will need to figure out how to solve the pinning/versioning question next week. Once Mauro is back online we will follow up.