Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active reviews count is incorrect #4392

Open
ajrbyers opened this issue Sep 6, 2024 · 1 comment · May be fixed by #4450
Open

Active reviews count is incorrect #4392

ajrbyers opened this issue Sep 6, 2024 · 1 comment · May be fixed by #4450
Assignees
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. priority-urgent size XS Extra small

Comments

@ajrbyers
Copy link
Member

ajrbyers commented Sep 6, 2024

Describe the bug
When viewing a list the number of active reviews a reviewer has doesn't look right.

Its possible that reviews that are withdrawn are not removed from the count.

Janeway version
1.7.0

Expected behavior
This count should only show the number of open reviews a user has.

active_reviews_count = models.ReviewAssignment.objects.filter(
is_complete=False,
reviewer=OuterRef("id"),
).values(
"reviewer_id",
).annotate(
rev_count=Count("reviewer_id"),
).values("rev_count")

@ajrbyers ajrbyers added bug Something's not working size XS Extra small priority-urgent dev-ready This issue has been refined and is ready for development. labels Sep 6, 2024
@ajrbyers ajrbyers self-assigned this Oct 8, 2024
ajrbyers added a commit that referenced this issue Oct 8, 2024
@ajrbyers ajrbyers linked a pull request Oct 8, 2024 that will close this issue
@LabPhonEA
Copy link

Hi, I am posting this query here, since this issue was created based on the original Freshdesk request (#9035, September 5, 2024), but please let me know if there is a better place (reopen the request or something else?).

We are still being asked regularly about this by puzzled editors. Here is the most recent one:

"I checked and none of them have reviewed in the past 6 months (although Ken showed one "active review", and so does that mean he is currently doing one..? If so, then maybe skip him on the list - but I looked around at other reviewers and I'm not sure that's what "active review" means, because many people have 2+, which doesn't seem right)."

I ask editors to please look at the list of potential reviewers as they are building the list of candidates for an article, so they will produce a list with better candidates, and to cut down on unnecessary work and emails for us. But their questions about the inconsistencies and subsequent explanations are almost as much work. And it does not reflect well on us (or Janeway, for that matter). Do you estimate that the bug fix will be implemented soon, or should I (temporarily?) ask editors to not use the reviewer list? Or something else?

Thank you.
Bernardo Rechea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. priority-urgent size XS Extra small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants