Ensures that active reviews count is accurate #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauromsl
requested changes
Dec 5, 2024
| @@ -49,7 +50,8 @@ def get_reviewers(article, candidate_queryset, exclude_pks): | |||
| ).exclude(date_complete__isnull=True).order_by("-date_complete") | |||
| ) | |||
| active_reviews_count = models.ReviewAssignment.objects.filter( | |||
| is_complete=False, | |||
| Q(date_complete__isnull=True) | Q(is_complete=True), | |||
There was a problem hiding this comment.
Did you mean to use an XOR operator?
Q objects and querysets can now be combined using ^ as the exclusive or (XOR) operator. XOR is natively supported on MariaDB and MySQL. For databases that do not support XOR, the query will be converted to an equivalent using AND, OR, and NOT.
https://docs.djangoproject.com/en/4.2/releases/4.1/#models
Also, it would be good to use a comment here explaining the implicitness of the query (we are trying to consider declined reviews) or maybe even use a variable/custom filter/custom manager method, e.g
INCOMPLETE_AND_NOT_DECLINED_FILTER = (Q(date_complete__isnull=True)^ Q(is_complete=True))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include both
date_completeandis_completein an OR filter when calculating a reviewers active review count.Closes #4392