Use press-level contact template at press level #3709 #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrbyers
reviewed
Jan 3, 2024
@ajrbyers Can do, but I thought the press-level clean and material themes weren't supported? Do we know anyone using them? Agree about the iffy path. We had a conversation about this a while back and I think the decision was not to change any of these dodgy theme template paths until we can decide on a good convention to standardize them all. Does that still hold here? |
mauromsl
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Please don't merge this in v1.5.1! It could introduce further bugs in the press-level templates that we haven't caught because Janeway was using the journal-level templates. Let's introduce it in v1.5.2 or later.
Closes #3709.