Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to meta tags #3692 #3714

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Improvements to meta tags #3692 #3714

merged 2 commits into from
Jan 25, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Sep 13, 2023

Closes #3692.

@joemull joemull changed the title Clean up meta tags block #3692 Improvements to meta tags #3692 Sep 13, 2023
ajrbyers
ajrbyers requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment inline. The new templatetag added isn't used, is this PR incomplete?

src/core/templatetags/fqdn.py Show resolved Hide resolved
@joemull joemull requested a review from ajrbyers December 5, 2023 11:35
@mauromsl mauromsl merged commit 9c7cce6 into master Jan 25, 2024
@mauromsl mauromsl deleted the 3692-meta-tags branch January 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

@ajrbyers ajrbyers ajrbyers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.5.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta tag improvements
3 participants
@joemull @ajrbyers @mauromsl