Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3670 adds support for multiple themes in repositories and fixes original preprint templates from the OLH theme. #3811

Merged
merged 9 commits into from
Dec 8, 2023
Merged

3670 adds support for multiple themes in repositories and fixes original preprint templates from the OLH theme. #3811

merged 9 commits into from
Dec 8, 2023

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Dec 7, 2023

  • Adds a new setting to determine which themese support repository themes
  • Updates the theme middleware to support multiple repository themes
  • Moves some common templates from material to common
  • Updates the old OLH templates so that they now work with the new data structure

Closes #3670

@ajrbyers ajrbyers changed the base branch from master to b_1_5_1 December 8, 2023 10:04
@ajrbyers ajrbyers requested a review from mauromsl December 8, 2023 10:04
Base automatically changed from b_1_5_1 to master December 8, 2023 15:26
mauromsl
mauromsl requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments but looks generally good!

src/utils/template_override_middleware.py Outdated Show resolved Hide resolved
src/core/janeway_global_settings.py Outdated Show resolved Hide resolved
src/themes/OLH/templates/core/base.html Outdated Show resolved Hide resolved
@ajrbyers ajrbyers requested a review from mauromsl December 8, 2023 16:05
@ajrbyers
Copy link
Member Author

ajrbyers commented Dec 8, 2023

@mauromsl I've made the requested changes and this is now ready for re-review.

mauromsl
mauromsl approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mauromsl mauromsl force-pushed the 3670-repository_themes branch from 97af173 to f060598 Compare December 8, 2023 16:44
@mauromsl mauromsl changed the base branch from master to b_1_5_1 December 8, 2023 16:44
@mauromsl mauromsl merged commit 4487f15 into b_1_5_1 Dec 8, 2023
1 check was pending
@mauromsl mauromsl deleted the 3670-repository_themes branch December 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.5.1 Archer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repository Themes
2 participants
@ajrbyers @mauromsl