Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3785 bugfix - control user if statement contents updated #3891

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

StephDriver
Copy link
Contributor

problem was with forms not communicating correctly with each other. Updated with code from @ajrbyers to fix this. Tested the fix.

Closes #3785

Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephDriver : While I understand the changes, I'm struggling to grasp why it resolves the reported problem. Could you comment on how that's the case? the previous nested form had the same action as this button, with the same inputs being posted

@StephDriver
Copy link
Contributor Author

StephDriver commented Mar 22, 2024

My notes on this solution are 'paste in Andy's code'- it was an issue I spent a lot of time investigating, could replicate but couldn't quite understand why it was happening, then I pair-programmed it with Andy and I'll admit I still don't understand how or why this change solves that problem - but I ran the same tests after his changes and the problem had gone away. So over to you to explain further @ajrbyers .

@ajrbyers
Copy link
Member

@StephDriver : While I understand the changes, I'm struggling to grasp why it resolves the reported problem. Could you comment on how that's the case? the previous nested form had the same action as this button, with the same inputs being posted

You can revert it and take a look but for some reason we couldn't get to the bottom of the first button in the list wouldn't fire the hijack process.

Anyway - nested <form> tags are not allowed in HTML5 and this does resolve the issue we saw.

@mauromsl mauromsl merged commit 1421bac into master Mar 22, 2024
1 check passed
@mauromsl mauromsl deleted the 3785-control_user_firstrow_button branch March 22, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control user button issue
3 participants