Update psycopg2-binary version #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joemull why is this merging into 4072-django-4-2 ? |
Sorry, I guess that's a bit confusing. I saw Mauro was updating the requirements file, is why. I'll go ahead and change the branch to master. |
mauromsl
requested changes
Apr 16, 2024
There was a problem hiding this comment.
Hey @joemull, I had a look at the changelog for psycopg2 and I think it is safe to do this upgrade. There is something wrong with your branch base though and it is bringing other commits with it. Can you rebase your branch first?
joemull
force-pushed
the
4072-django-4-2-psycopg-binary
branch
from
c45a627 to
fa09cec
Compare
mauromsl
approved these changes
Apr 19, 2024
|
blocked by #4073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent fresh installation I ran into an issue with pip install of psycopg2-binary. Version 2.8.6 uses an outdated installation method.
I am proposing bumping this to 2.9.8. I've read the changelog and don't believe there are any breaking changes for us between these versions, but please double-check. Version 2.9.9 drops support for python 3.6, so I don't think we should
go that far until we drop python 3.6.