Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unclosed footer link in clean theme #4284

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Fixes unclosed footer link in clean theme #4284

merged 2 commits into from
Jun 21, 2024

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Jun 18, 2024 •
edited
Loading

Closes #4285

@ajrbyers ajrbyers requested a review from joemull June 18, 2024 15:04
@ajrbyers ajrbyers changed the title Fixes unclosed footer link in clean. Fixes unclosed footer link in clean theme Jun 18, 2024
joemull
joemull requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth just breaking this line up a bit so that it is easier to read the nesting? I dislike making nitpick linting comments but I do believe that long HTML lines are partially to blame for bugs like this, because they make it harder to see when tags and template blocks like are not closed properly.

@joemull joemull assigned ajrbyers and unassigned joemull Jun 20, 2024
@ajrbyers ajrbyers requested a review from joemull June 20, 2024 09:10
@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Jun 20, 2024
@ajrbyers
Copy link
Member Author

Would it be worth just breaking this line up a bit so that it is easier to read the nesting? I dislike making nitpick linting comments but I do believe that long HTML lines are partially to blame for bugs like this, because they make it harder to see when tags and template blocks like are not closed properly.

It also breaks the golden rule: lint unto thyself. Just kidding, I've broken this one up but as discussed we should consider picking a consistent way to format HTML and CSS over multiple lines.

@joemull joemull requested review from mauromsl and StephDriver and removed request for mauromsl June 21, 2024 08:42
@joemull joemull assigned StephDriver and unassigned joemull Jun 21, 2024
StephDriver
StephDriver approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@StephDriver StephDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Jun 21, 2024
@ajrbyers ajrbyers merged commit 29e7e86 into master Jun 21, 2024
@ajrbyers ajrbyers deleted the clean-footer-link-fix branch June 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemull joemull joemull approved these changes

@StephDriver StephDriver StephDriver approved these changes

Assignees

@ajrbyers ajrbyers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclosed <a> tag in clean theme footer
3 participants
@ajrbyers @StephDriver @joemull