Close incomplete review assignments when an article is rejected #4305
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins: test this please |
ajrbyers
requested review from
mauromsl and
joemull
and removed request for
mauromsl
There was a problem hiding this comment.
Thank you for this @everreau --all the logic looks good to me, and we always appreciate a test!
Could we just put the line lengths down to PEP-8's max width of 80 chars? I know Janeway has lots of long lines but we are currently working on getting that down by linting the things we change. (We want to implement Black at some point but it is hard finding the right moment.)
|
@joemull done. I'm assuming this only applies to python code not templates. |
Thanks. Yes for now just Python, though we are considering the same max width of 80 for HTML and CSS. |
src/submission/models.py
Outdated
| @@ -1514,6 +1514,10 @@ def decline_article(self): | |||
| self.date_declined = timezone.now() | |||
| self.date_accepted = None | |||
| self.stage = STAGE_REJECTED | |||
|
|
|||
| self.incomplete_reviews().update(decision='withdrawn', | |||
There was a problem hiding this comment.
Can this be updated to use the constant value models.RD.DECISION_WITHDRAWN.value?
I asked Charlotte about this and she says if it's just an auto-notification she'd rather not. It's more likely to be interpreted as spam. |
Closes #4251
We found that open review counts for some reviewers were higher than expected because incomplete reviews from rejected articles were still open.