Fixed an issue with middle names and added support for page ranges in RIS and BIB exports (zotero, endnote, etc) #4385
Conversation
mauromsl
changed the title
ajrbyers
requested review from
StephDriver and
joemull
and removed request for
joemull
src/submission/models.py
Outdated
| def bibtex_author_list(self): | ||
| return " and ".join( | ||
| [author.full_name() for author in self.frozen_authors()], | ||
| ) |
There was a problem hiding this comment.
I believe the spec recommends "AND" (all uppercase) as the separator : https://bibtex.eu/fields/author/
There was a problem hiding this comment.
It all seems logical - I've added a single observation but it is on something at the edge of my knowledge so it may well not require any action. Please review the observation and judge whether changes are needed, I'm approving this so that it can just go through assuming changes are not required.
| @@ -1,7 +1,7 @@ | |||
| {% load settings %} | |||
| {% load encoding %} | |||
| {% if article.journal.is_conference %}@conference{% else %}@article{% endif %}{% templatetag openbrace %}{{ article.journal.code }} {{ article.id }}, | |||
| author = {{ article.author_list|latex_conform }}, | |||
There was a problem hiding this comment.
Line 3 has me puzzled, could well be my lack of understanding, but here's my observation. Please ignore if it a misunderstanding or not relevant:
I read this as a change from an output described by templatetag openbrace journal.article.code articleid, to templatetag openbrace journalarticle.codearticleid, -> i.e. that the last two terms have been concatenated because the space between them has been removed.
Was that intended?
There was a problem hiding this comment.
marking as changes requested only in as far as asking you to consider this observation before merging.
There was a problem hiding this comment.
Yes, the space makes thie field invalid.
Updates RIS and BIBTEX with additional information and