Add script to generate full ENDF/B-VII.1 library using NJOY #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangjg
reviewed
Feb 13, 2019
| formatter_class=CustomFormatter | ||
| ) | ||
| parser.add_argument('-d', '--destination', type=Path, default=Path('mcnp_endfb71'), | ||
| help='Directory to create new library in') |
There was a problem hiding this comment.
This argument destination is not used
generate_endf71.py
Outdated
| (neutron_dir / 'n-092_U_238.endf', thermal_dir / 'tsl-UinUO2.endf') | ||
| ] | ||
|
|
||
| temperatures = [250.0, 293.6, 600.0, 900.0, 1200.0, 2500.0] |
There was a problem hiding this comment.
may be helpful to allow users to optionally specify temperatures? Of course, one can also modify this script manually for any desired temperature list.
|
Thanks for reviewing this @liangjg! Just fixed the script per your suggestion. I didn't add temperatures as an option since it would be a little complicated, but I moved the definition of |
liangjg
approved these changes
Feb 13, 2019
|
@liangjg Sorry about that. Committers team didn't have write access on the new repo; that should be fixed now. |
|
No worries @paulromano . Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script will generate a full ENDF/B-VII.1 library including neutron, photon, thermal scattering, and windowed multipole data. Because running NJOY for 400+ nuclides takes quite a bit of time, the processing is parallelized using the Python multiprocessing module.
This script can serve as a template for processing other full libraries.