Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlaps #25

Merged
merged 9 commits into from
Jun 18, 2019
Merged

Overlaps #25

merged 9 commits into from
Jun 18, 2019

Conversation

pshriwise
Copy link
Collaborator

This adds plotting along with a customizable color in the same way that the background color is customized. Overlap plotting can be turned on/off with the Ctrl+P shortcut.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to use this, I get the following traceback:

Traceback (most recent call last):
  File "/home/romano/openmc-plotter/openmc-plotter", line 938, in <module>
    mainWindow.loadGui()
  File "/home/romano/openmc-plotter/openmc-plotter", line 92, in loadGui
    self.colorDialog.updateDialogValues()
  File "/home/romano/openmc-plotter/plotgui.py", line 1015, in updateDialogValues
    self.updateOverlapColor()
  File "/home/romano/openmc-plotter/plotgui.py", line 1075, in updateOverlapColor
    color = self.model.activeView.overlap_color
AttributeError: 'PlotView' object has no attribute 'overlap_color'

I made sure to use the latest develop branch of OpenMC, so that shouldn't be the issue.

plotmodel.py Outdated Show resolved Hide resolved
@pshriwise
Copy link
Collaborator Author

It's likely this is because there is an out of date plot_settings.pkl file in the model directory. We check the version number when loading plot views but not when starting up the GUI. I've added a check for that now, so it should ignore those settings an generate the default view.

@paulromano
Copy link
Contributor

Ah, ok, that makes sense. Now it works!

@paulromano paulromano merged commit ad007c7 into openmc-dev:master Jun 18, 2019
@pshriwise pshriwise deleted the overlap branch July 9, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants