Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize API #41

Closed
sunxiaojian opened this issue May 22, 2022 · 1 comment
Closed

Optimize API #41

sunxiaojian opened this issue May 22, 2022 · 1 comment

Comments

@sunxiaojian
Copy link
Contributor

sunxiaojian commented May 22, 2022

  1. Add struct object model
    统一struct构建方式,帮助快速完成struct的构建

  2. Optimize empty method
    第一种:完全没必要实现的方法,需要隐掉
    第二种:可实现,可不实现的方法,需要设置default,不应该出现即可以在 A方法同时也可以在B 方法中实现的逻辑,比如 init 和 validate

  3. Add sourcerecord and sinkrecord
    source 中的position和offset 在sink端中是不需要的,如果在sink端消费record时,对api中字段的释义不明确,就会造成很多的社区沟通成本,这样也会显的api不是很专一,所以抽象的好处是能让开发者看到的字段和api都是能可解释的且都是有明确含义的;这样也会对未来sink和source对象的独立的功能扩展和开发带来便利

  4. Add offset writer abstraction
    包装RecordOffset使用使用,保证每个任务的offset的唯一性

..........

@sunxiaojian sunxiaojian changed the title Add the API of struct Optimize API May 23, 2022
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue May 24, 2022
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue May 24, 2022
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue Jun 4, 2022
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue Jun 4, 2022
sunxiaojian added a commit to sunxiaojian/openconnect that referenced this issue Jun 4, 2022
odbozhou pushed a commit that referenced this issue Jun 8, 2022
* Add struct object and optimize schema and schema builder API #41

* add offset storage writer #41

* add getter and setter method #41

* add SchemaAndValue #41

* add logical type #41

* Schemabuilder add required method

* schema add  hashCode and equals method

* fixed doc method

* Field add equals and hashcode method
@odbozhou
Copy link
Contributor

metged

odbozhou pushed a commit that referenced this issue Jun 21, 2022
* SinkTask and SourceTask implement the validate method apache/rocketmq-connect#85

* Adjust the init and start methods of the component interface

* Set pause and resume to deprecated methods. It feels like they can be removed

* Add struct object and optimize schema and schema builder API #41

* add offset storage writer #41

* add getter and setter method #41

* add SchemaAndValue #41

* add logical type #41

* Schemabuilder add required method

* schema add  hashCode and equals method

* fixed doc method

* Field add equals and hashcode method

* optimize api #85

* Optimize transform api #45

* Optimize transform api and add RecordConverter
odbozhou pushed a commit that referenced this issue Jul 14, 2022
* SinkTask and SourceTask implement the validate method apache/rocketmq-connect#85

* Adjust the init and start methods of the component interface

* Set pause and resume to deprecated methods. It feels like they can be removed

* Add struct object and optimize schema and schema builder API #41

* add offset storage writer #41

* add getter and setter method #41

* add SchemaAndValue #41

* add logical type #41

* Schemabuilder add required method

* schema add  hashCode and equals method

* fixed doc method

* Field add equals and hashcode method

* optimize api #85

* Optimize transform api #45

* Optimize transform api and add RecordConverter

* Optimize the source task commit method #51

* add batch commit #51
odbozhou pushed a commit that referenced this issue Jul 20, 2022
…54)

* SinkTask and SourceTask implement the validate method apache/rocketmq-connect#85

* Adjust the init and start methods of the component interface

* Set pause and resume to deprecated methods. It feels like they can be removed

* Add struct object and optimize schema and schema builder API #41

* add offset storage writer #41

* add getter and setter method #41

* add SchemaAndValue #41

* add logical type #41

* Schemabuilder add required method

* schema add  hashCode and equals method

* fixed doc method

* Field add equals and hashcode method

* optimize api #85

* Optimize transform api #45

* Optimize transform api and add RecordConverter

* Connectrecord add a key field to identify the unique data #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants