Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry for dependency management and packaging #20

Merged
merged 24 commits into from
May 30, 2024
Merged

Conversation

crdanielbusch
Copy link
Contributor

@crdanielbusch crdanielbusch commented May 29, 2024

Description

  • Add Poetry for dependency management and packaging -> add all dependencies in pyproject.toml
  • Adjust action.yaml and ci.yaml to Poetry
  • Check that Poetry builds openmethane_prior package in GitHub workflow
  • Check that Poetry installs openmethane_prior package in GitHub workflow

Small changes unrelated to Poetry:

  • Switch to environment variables for CDS API authentication
  • Update commands to run the script in Readme
  • Update list of authors in pyproject.toml
  • snake case module names and remove om prefix (low priority, will be done in another pull request)

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)

Notes

@crdanielbusch crdanielbusch self-assigned this May 29, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@lewisjared
Copy link
Collaborator

One other thing, can you add a target into the Makefile to build the venv? It should be in an existing copier templated project

Makefile Outdated Show resolved Hide resolved
crdanielbusch and others added 2 commits May 30, 2024 17:17
@lewisjared lewisjared merged commit 54002b9 into main May 30, 2024
3 checks passed
@lewisjared lewisjared deleted the add-poetry branch May 30, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants