-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container version #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aethr
force-pushed
the
container-version
branch
from
November 22, 2024 04:03
db7c2c7
to
08a9e3f
Compare
aethr
force-pushed
the
container-version
branch
2 times, most recently
from
November 25, 2024 05:25
bd19ee8
to
bb1ed2c
Compare
After a full run of the prior, the output file has these global attributes (from
The version in |
This includes a history attribute that records the time the file was generated, the command and package version at the time of creation.
This make task became unusable when the docker-based "run" target was added. It also wasn't updated when the method for passing in start and end time arguments was updated.
It's unlikely that users would think to look in the history attribute to find software version information. By putting the version in its own explicitly labelled attribute, it's easier to find and also more readily available for parsing. Fix inputs
aethr
force-pushed
the
container-version
branch
from
November 25, 2024 22:31
bb1ed2c
to
d000758
Compare
prayner
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the openmethane-prior package version available inside the container so that data files can be annotated with the version that was used to process them.
Checklist
Please confirm that this pull request has done the following:
changelog/
Notes