Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support: Schema fixes for MDS 1.1.0 #699

Merged
merged 16 commits into from
Sep 24, 2021
Merged

Support: Schema fixes for MDS 1.1.0 #699

merged 16 commits into from
Sep 24, 2021

Conversation

schnuerle
Copy link
Member

Explain pull request

Schema fixes for MDS 1.1.0. This will create a new release called 1.1.1.

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • provider

@schnuerle schnuerle requested a review from a team as a code owner September 20, 2021 17:49
@schnuerle schnuerle added Schema Implications for JSON Schema or OpenAPI minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. State Machine Changes in the vehicle state events and state machine diagram labels Sep 20, 2021
@schnuerle schnuerle added this to the 1.1.1 milestone Sep 20, 2021
@schnuerle schnuerle changed the title Ms 1.1.0 fixes Support: Schema fixes for MDS 1.1.0 Sep 20, 2021
@schnuerle schnuerle linked an issue Sep 20, 2021 that may be closed by this pull request
"removed" missing "comms_restored" option in provider schemas #690
Closed
@schnuerle schnuerle marked this pull request as draft September 20, 2021 18:09
@schnuerle schnuerle self-assigned this Sep 21, 2021
@schnuerle schnuerle linked an issue Sep 22, 2021 that may be closed by this pull request
Version number is 1.0.x for 1.1.0 release #669
Closed
This was referenced Sep 23, 2021
Closed
Closed
invadervimdev
invadervimdev previously approved these changes Sep 23, 2021
View reviewed changes
Copy link

@invadervimdev invadervimdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only nitpicking I see is to update the examples right above the pattern. Otherwise, LGTM!

@schnuerle schnuerle marked this pull request as ready for review September 24, 2021 15:31
@schnuerle schnuerle merged commit 349e9c0 into main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invadervimdev invadervimdev invadervimdev left review comments

@thekaveman thekaveman Awaiting requested review from thekaveman

Assignees

@schnuerle schnuerle

Labels
minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

"removed" missing "comms_restored" option in provider schemas Version number is 1.0.x for 1.1.0 release
2 participants
@schnuerle @invadervimdev