Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) Add missing stubs to framework mock #1105

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR adds stubs for functionality that was missing in the framework mock. With these, we shouldn't need to use partial mocks anywhere near as much in most of our repos.

Screenshots

Related Issue

Other

Copy link
Collaborator

@NethmiRodrigo NethmiRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much @denniskigen!

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Size Change: -79 kB (-1.43%)

Total Size: 5.46 MB

Filename Size Change
packages/shell/esm-app-shell/dist/3b995e938d50c19e.js 0 B -57.6 kB (removed) 🏆
packages/shell/esm-app-shell/dist/openmrs.24b962c376639472.js 0 B -21.4 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size
packages/apps/esm-devtools-app/dist/593.js 149 kB
packages/apps/esm-devtools-app/dist/642.js 21.1 kB
packages/apps/esm-devtools-app/dist/657.js 7.02 kB
packages/apps/esm-devtools-app/dist/735.js 2.63 kB
packages/apps/esm-devtools-app/dist/762.js 4.08 kB
packages/apps/esm-devtools-app/dist/788.js 42.9 kB
packages/apps/esm-devtools-app/dist/875.js 11.6 kB
packages/apps/esm-devtools-app/dist/889.js 293 kB
packages/apps/esm-devtools-app/dist/988.js 326 B
packages/apps/esm-devtools-app/dist/main.js 3.23 kB
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.28 kB
packages/apps/esm-help-menu-app/dist/167.js 1.07 kB
packages/apps/esm-help-menu-app/dist/248.js 7.07 kB
packages/apps/esm-help-menu-app/dist/611.js 2.45 kB
packages/apps/esm-help-menu-app/dist/642.js 21.1 kB
packages/apps/esm-help-menu-app/dist/657.js 7.02 kB
packages/apps/esm-help-menu-app/dist/662.js 147 kB
packages/apps/esm-help-menu-app/dist/735.js 2.63 kB
packages/apps/esm-help-menu-app/dist/788.js 42.9 kB
packages/apps/esm-help-menu-app/dist/889.js 293 kB
packages/apps/esm-help-menu-app/dist/958.js 3.71 kB
packages/apps/esm-help-menu-app/dist/main.js 8.54 kB
packages/apps/esm-help-menu-app/dist/openmrs-esm-help-menu-app.js 3.23 kB
packages/apps/esm-implementer-tools-app/dist/271.js 723 B
packages/apps/esm-implementer-tools-app/dist/289.js 14.1 kB
packages/apps/esm-implementer-tools-app/dist/319.js 639 B
packages/apps/esm-implementer-tools-app/dist/336.js 137 kB
packages/apps/esm-implementer-tools-app/dist/36.js 2.49 kB
packages/apps/esm-implementer-tools-app/dist/426.js 27.8 kB
packages/apps/esm-implementer-tools-app/dist/441.js 4.38 kB
packages/apps/esm-implementer-tools-app/dist/448.js 4.64 kB
packages/apps/esm-implementer-tools-app/dist/460.js 748 B
packages/apps/esm-implementer-tools-app/dist/56.js 3.08 kB
packages/apps/esm-implementer-tools-app/dist/574.js 584 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.93 kB
packages/apps/esm-implementer-tools-app/dist/625.js 564 B
packages/apps/esm-implementer-tools-app/dist/631.js 3.45 kB
packages/apps/esm-implementer-tools-app/dist/642.js 21.1 kB
packages/apps/esm-implementer-tools-app/dist/644.js 723 B
packages/apps/esm-implementer-tools-app/dist/657.js 7.03 kB
packages/apps/esm-implementer-tools-app/dist/667.js 121 kB
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/757.js 563 B
packages/apps/esm-implementer-tools-app/dist/775.js 134 kB
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB
packages/apps/esm-implementer-tools-app/dist/807.js 562 B
packages/apps/esm-implementer-tools-app/dist/833.js 691 B
packages/apps/esm-implementer-tools-app/dist/845.js 6.43 kB
packages/apps/esm-implementer-tools-app/dist/889.js 293 kB
packages/apps/esm-implementer-tools-app/dist/main.js 20.8 kB
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.39 kB
packages/apps/esm-login-app/dist/111.js 1.22 kB
packages/apps/esm-login-app/dist/122.js 266 B
packages/apps/esm-login-app/dist/126.js 2.5 kB
packages/apps/esm-login-app/dist/173.js 1.22 kB
packages/apps/esm-login-app/dist/224.js 258 B
packages/apps/esm-login-app/dist/236.js 272 B
packages/apps/esm-login-app/dist/240.js 366 B
packages/apps/esm-login-app/dist/271.js 962 B
packages/apps/esm-login-app/dist/272.js 24.4 kB
packages/apps/esm-login-app/dist/319.js 879 B
packages/apps/esm-login-app/dist/336.js 233 B
packages/apps/esm-login-app/dist/460.js 967 B
packages/apps/esm-login-app/dist/539.js 300 B
packages/apps/esm-login-app/dist/56.js 3.07 kB
packages/apps/esm-login-app/dist/574.js 687 B
packages/apps/esm-login-app/dist/593.js 149 kB
packages/apps/esm-login-app/dist/625.js 762 B
packages/apps/esm-login-app/dist/627.js 258 B
packages/apps/esm-login-app/dist/63.js 16.5 kB
packages/apps/esm-login-app/dist/642.js 21.1 kB
packages/apps/esm-login-app/dist/644.js 962 B
packages/apps/esm-login-app/dist/657.js 7.02 kB
packages/apps/esm-login-app/dist/673.js 286 B
packages/apps/esm-login-app/dist/735.js 2.62 kB
packages/apps/esm-login-app/dist/757.js 908 B
packages/apps/esm-login-app/dist/788.js 42.9 kB
packages/apps/esm-login-app/dist/80.js 30.6 kB
packages/apps/esm-login-app/dist/807.js 1.13 kB
packages/apps/esm-login-app/dist/833.js 902 B
packages/apps/esm-login-app/dist/889.js 293 kB
packages/apps/esm-login-app/dist/93.js 2.04 kB
packages/apps/esm-login-app/dist/main.js 58.9 kB
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.46 kB
packages/apps/esm-offline-tools-app/dist/18.js 91.4 kB
packages/apps/esm-offline-tools-app/dist/224.js 6.29 kB
packages/apps/esm-offline-tools-app/dist/271.js 1.19 kB
packages/apps/esm-offline-tools-app/dist/319.js 1.13 kB
packages/apps/esm-offline-tools-app/dist/460.js 1.3 kB
packages/apps/esm-offline-tools-app/dist/56.js 3.08 kB
packages/apps/esm-offline-tools-app/dist/574.js 1.03 kB
packages/apps/esm-offline-tools-app/dist/601.js 142 kB
packages/apps/esm-offline-tools-app/dist/625.js 1.03 kB
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB
packages/apps/esm-offline-tools-app/dist/642.js 21.1 kB
packages/apps/esm-offline-tools-app/dist/644.js 1.19 kB
packages/apps/esm-offline-tools-app/dist/657.js 7.03 kB
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB
packages/apps/esm-offline-tools-app/dist/757.js 1.19 kB
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB
packages/apps/esm-offline-tools-app/dist/833.js 1.21 kB
packages/apps/esm-offline-tools-app/dist/889.js 293 kB
packages/apps/esm-offline-tools-app/dist/947.js 8.66 kB
packages/apps/esm-offline-tools-app/dist/main.js 107 kB
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.38 kB
packages/apps/esm-primary-navigation-app/dist/271.js 270 B
packages/apps/esm-primary-navigation-app/dist/319.js 232 B
packages/apps/esm-primary-navigation-app/dist/460.js 266 B
packages/apps/esm-primary-navigation-app/dist/482.js 15.2 kB
packages/apps/esm-primary-navigation-app/dist/513.js 146 kB
packages/apps/esm-primary-navigation-app/dist/574.js 231 B
packages/apps/esm-primary-navigation-app/dist/577.js 7.64 kB
packages/apps/esm-primary-navigation-app/dist/619.js 6.45 kB
packages/apps/esm-primary-navigation-app/dist/625.js 231 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB
packages/apps/esm-primary-navigation-app/dist/644.js 270 B
packages/apps/esm-primary-navigation-app/dist/657.js 7.03 kB
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB
packages/apps/esm-primary-navigation-app/dist/757.js 237 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB
packages/apps/esm-primary-navigation-app/dist/807.js 291 B
packages/apps/esm-primary-navigation-app/dist/833.js 258 B
packages/apps/esm-primary-navigation-app/dist/889.js 293 kB
packages/apps/esm-primary-navigation-app/dist/933.js 3.63 kB
packages/apps/esm-primary-navigation-app/dist/958.js 24.3 kB
packages/apps/esm-primary-navigation-app/dist/main.js 29.8 kB
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.38 kB
packages/framework/esm-api/dist/openmrs-esm-api.js 16.2 kB
packages/framework/esm-config/dist/openmrs-esm-module-config.js 8.08 kB
packages/framework/esm-context/dist/openmrs-esm-context.js 1.09 kB
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.89 kB
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 891 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 24.6 kB
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.66 kB
packages/framework/esm-framework/dist/126.openmrs-esm-framework.js 2.14 kB
packages/framework/esm-framework/dist/278.openmrs-esm-framework.js 14.5 kB
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.93 kB
packages/framework/esm-framework/dist/619.openmrs-esm-framework.js 6.49 kB
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.3 kB
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.65 kB
packages/framework/esm-framework/dist/746.openmrs-esm-framework.js 6.14 kB
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB
packages/framework/esm-framework/dist/openmrs-esm-framework.js 428 kB
packages/framework/esm-globals/dist/openmrs-esm-globals.js 791 B
packages/framework/esm-navigation/dist/openmrs-esm-navigation.js 9.34 kB
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 15.8 kB
packages/framework/esm-routes/dist/openmrs-esm-utils.js 4.67 kB
packages/framework/esm-state/dist/openmrs-esm-state.js 910 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 131 kB
packages/framework/esm-translations/dist/openmrs-esm-core-translations.js 1.87 kB
packages/framework/esm-utils/dist/openmrs-esm-utils.js 45.4 kB
packages/shell/esm-app-shell/dist/0e69d9ec4853cfe2.js 958 B
packages/shell/esm-app-shell/dist/108de29b7c1b7ac8.js 6.99 kB
packages/shell/esm-app-shell/dist/14be18646eeccd9a.js 253 B
packages/shell/esm-app-shell/dist/160b31a143ce87fb.js 1.22 kB
packages/shell/esm-app-shell/dist/20e2dd6b8ba9fdd0.js 253 B
packages/shell/esm-app-shell/dist/22d2389728f15f76.js 18.3 kB
packages/shell/esm-app-shell/dist/2b553874176a2d5e.js 912 B
packages/shell/esm-app-shell/dist/2cc5179a2a17e577.js 911 B
packages/shell/esm-app-shell/dist/2ddface0d88d7441.js 43 kB
packages/shell/esm-app-shell/dist/3644c66a25798faa.js 168 kB
packages/shell/esm-app-shell/dist/39c27dcaf13969ce.js 6.77 kB
packages/shell/esm-app-shell/dist/4600ae74dce9320d.js 1.17 kB
packages/shell/esm-app-shell/dist/4d55947c2d077956.js 1.19 kB
packages/shell/esm-app-shell/dist/53ffa8a3626d97a5.js 36.5 kB
packages/shell/esm-app-shell/dist/5d81ff06955da089.js 1.22 kB
packages/shell/esm-app-shell/dist/613d95f10655d313.js 2.52 kB
packages/shell/esm-app-shell/dist/85bbfd1b2f124ed9.js 3.33 kB
packages/shell/esm-app-shell/dist/85d9e1ec051fd113.js 2.84 kB
packages/shell/esm-app-shell/dist/8711659b05d659a3.js 9.36 kB
packages/shell/esm-app-shell/dist/8c7c69fc0e32ca48.js 2.6 kB
packages/shell/esm-app-shell/dist/91073574b592fe62.js 57.6 kB
packages/shell/esm-app-shell/dist/9306486d6a162aea.js 1.59 kB
packages/shell/esm-app-shell/dist/93f8566244107be0.js 628 B
packages/shell/esm-app-shell/dist/9e544f6471561cb4.js 912 B
packages/shell/esm-app-shell/dist/a05840be5ec988e7.js 1 kB
packages/shell/esm-app-shell/dist/a0e789646c4db6de.js 15.1 kB
packages/shell/esm-app-shell/dist/b16c958eec8c1cf0.js 628 B
packages/shell/esm-app-shell/dist/b83e4961d0a5a387.js 934 B
packages/shell/esm-app-shell/dist/b88532bde74b513a.js 9.41 kB
packages/shell/esm-app-shell/dist/bbed6140658041e0.js 3.23 kB
packages/shell/esm-app-shell/dist/c13eac382178cd3b.js 167 kB
packages/shell/esm-app-shell/dist/cfe2ad41ed072f47.js 6.63 kB
packages/shell/esm-app-shell/dist/d4eb894015ccfa38.js 3.42 kB
packages/shell/esm-app-shell/dist/d7b53090c51a6e8e.js 1.19 kB
packages/shell/esm-app-shell/dist/d8ae446a9adb1e6a.js 3.07 kB
packages/shell/esm-app-shell/dist/eb08fa85c76e87f5.js 5.53 kB
packages/shell/esm-app-shell/dist/openmrs.71146ccd213dbd0a.js 21.4 kB
packages/shell/esm-app-shell/dist/service-worker.js 46.4 kB
packages/tooling/openmrs/dist/cli.js 2.96 kB
packages/tooling/openmrs/dist/commands/assemble.js 3.31 kB
packages/tooling/openmrs/dist/commands/build.js 1.32 kB
packages/tooling/openmrs/dist/commands/debug.js 543 B
packages/tooling/openmrs/dist/commands/develop.js 2.71 kB
packages/tooling/openmrs/dist/commands/index.js 437 B
packages/tooling/openmrs/dist/commands/start.js 850 B
packages/tooling/openmrs/dist/index.js 517 B
packages/tooling/openmrs/dist/runner.js 640 B
packages/tooling/openmrs/dist/utils/config.js 726 B
packages/tooling/openmrs/dist/utils/debugger.js 575 B
packages/tooling/openmrs/dist/utils/dependencies.js 643 B
packages/tooling/openmrs/dist/utils/helpers.js 397 B
packages/tooling/openmrs/dist/utils/importmap.js 3.07 kB
packages/tooling/openmrs/dist/utils/index.js 443 B
packages/tooling/openmrs/dist/utils/logger.js 368 B
packages/tooling/openmrs/dist/utils/npmConfig.js 831 B
packages/tooling/openmrs/dist/utils/untar.js 725 B
packages/tooling/openmrs/dist/utils/variables.js 192 B
packages/tooling/openmrs/dist/utils/webpack.js 278 B
packages/tooling/webpack-config/dist/index.js 3.61 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants