Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3094: Removing Warning modal and leveraging workspace promptBeforeClosing functionality #205

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

vasharma05
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR removes the WarningModal for the following reasons:

  1. Workspace provides the same functionality for prompting when closing form with unsaved changes.
  2. Warning Modal was having a lot of UI conflicts with other components

Screenshots

Screen.Recording.2024-04-23.at.11.42.51.mov

Related Issue

https://issues.openmrs.org/browse/O3-3094

Other

Dependent on openmrs/openmrs-esm-patient-chart#1804

Copy link

github-actions bot commented Apr 23, 2024

Size Change: -237 kB (-18%) 👏

Total Size: 1.06 MB

Filename Size Change
dist/373.js 0 B -237 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/100.js 2.41 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 169 kB 0 B
dist/327.js 1.58 kB 0 B
dist/353.js 3.02 kB 0 B
dist/402.js 237 kB 0 B
dist/459.js 6.07 kB 0 B
dist/505.js 6.95 kB 0 B
dist/540.js 2.63 kB 0 B
dist/606.js 2.23 kB 0 B
dist/616.js 202 kB 0 B
dist/791.js 9.8 kB 0 B
dist/859.js 830 B 0 B
dist/886.js 6.59 kB 0 B
dist/942.js 482 B 0 B
dist/981.js 85.7 kB 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 311 kB -2 B (0%)
dist/openmrs-form-engine-lib.js 3.57 kB -2 B (0%)

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @vasharma05!

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pirupius pirupius merged commit f161fa2 into main Apr 23, 2024
5 checks passed
@pirupius pirupius deleted the fix/O3-3094 branch April 23, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants