(chore) O3-3540: Bump @carbon/react to v1.74.0

[dilankavishka]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

Upgrade to @carbon/react 1.73.0

Screenshots

Related Issue

https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-3540?jql=project%20%3D%20%22O3%22%20AND%20assignee%20%3D%20empty%20ORDER%20BY%20created%20DESC

Other

[dilankavishka]

@brandones Could you please review this?

[samuelmale]

@dilankavishka can we have Carbon as a peer dependency instead?

[dilankavishka]

@samuelmale do you mean like, add both devDependencies and peerDependencies like other apps?

[samuelmale]

@dilankavishka yes! Just like @openmrs/esm-framework.

[dilankavishka]

@samuelmale Sure! I will do that.

[dilankavishka]

@samuelmale I made the changes. can you take look now please?

[samuelmale]

@dilankavishka is there a plan of bumping Carbon across the framework? If yes, is the agreed-upon version ~1.73.0? cc: @denniskigen @ibacher

[dilankavishka]

@samuelmale I think it's says to upgrade the version to a recent one. I did the same thing for the esm-fast-data-entry app also. but it's @carbon/react": "1.71.0"

[samuelmale]

@dilankavishka the failing tests are likely related to the Carbon bump. Can you investigate why or calibrate the Carbon version?

[denniskigen]

Hey, @dilankavishka, @samuelmale, there's a separate effort trying to get everything on ^1.71.0 ongoing at the moment. It'd be ideal use that version here too.

[ibacher]

In order for Carbon to be used as a peerdep, we do need to agree on a version. Unfortunately, I think that means we're requiring a very specific version, e.g., 1.71.0 or w/e makes sense across the app because Carbon's versions are not reliably non-breaking, even across patch versions. For right now, I think the goal should be getting everything on say 1.74.0 (the most recent release as of this moment) and then we can migrate to using it as a peer dependency.

[dilankavishka]

@dilankavishka the failing tests are likely related to the Carbon bump. Can you investigate why or calibrate the Carbon version?

Sure! Let me do that.

[dilankavishka]

@denniskigen, @ibacher Should I need to change the version to 1.71.0 or Keep the version 1.74.0 and go through ?

[samuelmale]

The goal is to support the latest Carbon version, v1.74.0. For now, let's treat Carbon as a normal dependency and ensure everything works seamlessly, and later make Carbon a peer dependency!

[dilankavishka]

@samuelmale I made the changes.

[samuelmale]

@dilankavishka are you able to look into the failing tests?

[dilankavishka]

@samuelmale Yeah i'll do that