(fix) O3-3175: Remove Breadcrumbs menu from Patient Chart (#1832)

* (fix)- O3-3175 Remove Breadcrumbs

* Remove translation strings

* Remove more occurrences of breadcrumbs

---------

Co-authored-by: Dennis Kigen <[email protected]>

README.md

@@ -133,16 +133,13 @@ yarn
 The patient chart consists of the following parts:
 
 - Navigation menu
-- Breadcrumbs menu
 - Patient header
 - Chart review / Dashboards
 - Workspace
 - Side menu
 
 The **navigation menu** lives on the left side of the screen and provides links to dashboards in the patient chart.
 
-The **breadcrumbs menu** gets shown at the top of the page under the navigation bar. It shows the user their current location relative to the information architecture and helps them quickly navigate to a parent level or previous step.
-
 The **patient header** contains the [patient banner](packages/esm-patient-banner-app/README.md). Uninvasive notifications also appear in this area following actions such as form submissions.
 
 The **chart review** area is the main part of the screen. It displays whatever dashboard is active.

packages/esm-patient-chart-app/src/index.ts

@@ -1,5 +1,4 @@
 import {
-  registerBreadcrumbs,
   defineConfigSchema,
   getAsyncLifecycle,
   getSyncLifecycle,
@@ -9,7 +8,7 @@ import {
 import { createDashboardLink } from '@openmrs/esm-patient-common-lib';
 import * as PatientCommonLib from '@openmrs/esm-patient-common-lib';
 import { esmPatientChartSchema } from './config-schema';
-import { moduleName, spaBasePath } from './constants';
+import { moduleName } from './constants';
 import { summaryDashboardMeta, encountersDashboardMeta } from './dashboard.meta';
 import { setupOfflineVisitsSync, setupCacheableRoutes } from './offline';
 import { genericDashboardConfigSchema } from './side-nav/generic-dashboard.component';
@@ -45,42 +44,6 @@ export function startupApp() {
   defineExtensionConfigSchema('nav-group', genericNavGroupConfigSchema);
   defineExtensionConfigSchema('dashboard', genericDashboardConfigSchema);
 
-  /**
-   * This comment tells i18n to still keep the following translation keys (DO NOT DELETE THESE):
-   *
-   * t('patientBreadcrumb', 'Patient')
-   * t('Patient Summary dashboard', 'Patient Summary dashboard')
-   * t('Allergies dashboard', 'Allergies dashboard')
-   * t('Appointments dashboard', 'Appointments dashboard')
-   * t('Vitals & Biometrics dashboard', 'Vitals & Biometrics dashboard')
-   * t('Medications dashboard', 'Medications dashboard')
-   * t('Visits dashboard', 'Visits dashboard')
-   * t('Conditions dashboard', 'Conditions dashboard')
-   * t('Attachments dashboard', 'Attachments dashboard')
-   * t('Programs dashboard', 'Programs dashboard')
-   * t('Offline Actions dashboard', 'Offline Actions dashboard')
-   * t('Forms & Notes dashboard', 'Forms & Notes dashboard')
-   * t('Results Viewer dashboard', 'Results Viewer dashboard')
-   */
-  registerBreadcrumbs([
-    {
-      path: spaBasePath,
-      title: () => Promise.resolve(window.i18next.t('patientBreadcrumb', { defaultValue: 'Patient', ns: moduleName })),
-      parent: `${window.spaBase}/home`,
-    },
-    {
-      path: `${spaBasePath}/:view`,
-      title: ([_, key]) =>
-        Promise.resolve(
-          window.i18next.t(`${decodeURIComponent(key)} dashboard`, {
-            ns: moduleName,
-            defaultValue: `${decodeURIComponent(key)} dashboard`,
-          }),
-        ),
-      parent: spaBasePath,
-    },
-  ]);
-
   registerFeatureFlag(
     'rde',
     'Retrospective Data Entry',

packages/esm-patient-chart-app/src/patient-chart/patient-chart.component.tsx

@@ -56,7 +56,6 @@ const PatientChart: React.FC = () => {
               workspaceWindowState === 'normal' && active ? styles.closeWorkspace : styles.activeWorkspace,
             )}
           >
-            <ExtensionSlot name="breadcrumbs-slot" />
             {isLoadingPatient ? (
               <Loader />
             ) : (

packages/esm-patient-chart-app/translations/en.json

@@ -4,11 +4,8 @@
   "addPastVisitText": "You can add a new past visit or update an old one. Choose from one of the options below to continue.",
   "all": "All",
   "allEncounters": "All encounters",
-  "Allergies dashboard": "Allergies dashboard",
   "appointmentCheckedIn": "Appointment checked in",
   "appointmentMarkedChecked": "Appointment marked as Checked In",
-  "Appointments dashboard": "Appointments dashboard",
-  "Attachments dashboard": "Attachments dashboard",
   "cancel": "Cancel",
   "cancelActiveVisitConfirmation": "Are you sure you want to cancel this active visit?",
   "cancellingVisit": "Cancelling visit",
@@ -18,7 +15,6 @@
   "causeOfDeath_title": "Cause of Death",
   "checkFilters": "Check the filters above",
   "close": "Close",
-  "Conditions dashboard": "Conditions dashboard",
   "confirm": "Confirm",
   "confirmDeceased": "Confirm Deceased",
   "confirmDeletingVisitTextWithStartAndEndDate": "Are you sure you want to delete {{visit}} which started {{visitStartDate}} and ended {{visitEndDate}}?",
@@ -69,7 +65,6 @@
   "fieldRequired": "This field is required",
   "filterByEncounterType": "Filter by encounter type",
   "form": "Form name",
-  "Forms & Notes dashboard": "Forms & Notes dashboard",
   "goToThisEncounter": "Go to this encounter",
   "indication": "Indication",
   "invalidTimeFormat": "Invalid time format",
@@ -86,7 +81,6 @@
   "markDeceased": "Mark deceased",
   "markingPatientDeceasedInfoText": "Marking the patient as deceased will end any active visits for this patient",
   "medications": "Medications",
-  "Medications dashboard": "Medications dashboard",
   "missingVisitType": "Missing visit type",
   "modifyVisitDate": "Modify visit date",
   "movePatient": "Move patient",
@@ -102,7 +96,6 @@
   "noEncountersToDisplay": "No encounters to display",
   "noObservationsFound": "No observations found",
   "notes": "Notes",
-  "Offline Actions dashboard": "Offline Actions dashboard",
   "optional": "optional",
   "orderDurationAndUnit": "for {{duration}} {{durationUnit}}",
   "orderIndefiniteDuration": "Indefinite duration",
@@ -115,10 +108,7 @@
   "pastVisitErrorText": "Past Visit Error",
   "pastVisits": "Past Visits",
   "Patient Summary": "Patient Summary",
-  "Patient Summary dashboard": "Patient Summary dashboard",
-  "patientBreadcrumb": "Patient",
   "program": "Program",
-  "Programs dashboard": "Programs dashboard",
   "provider": "Provider",
   "quantity": "Quantity",
   "queueAddedSuccessfully": "Patient has been added to the queue successfully.",
@@ -127,7 +117,6 @@
   "record": "Record",
   "refills": "Refills",
   "refreshToTryAgain": "Please refresh to try again",
-  "Results Viewer dashboard": "Results Viewer dashboard",
   "retrospectiveEntry": "Retrospective Entry",
   "searchForAVisitType": "Search for a visit type",
   "searchForCauseOfDeath": "Search for a cause of death",
@@ -173,7 +162,6 @@
   "visitRestoredSuccessfully": "{{visit}} restored successfully",
   "visits": "visits",
   "Visits": "Visits",
-  "Visits dashboard": "Visits dashboard",
   "visitStartDatetime": "Visit start date and time",
   "visitStarted": "Visit started",
   "visitStartedSuccessfully": "{{visit}} started successfully",
@@ -183,6 +171,5 @@
   "visitType": "Visit type",
   "visitType_title": "Visit Type",
   "visitTypeRequired": "Visit type is required",
-  "Vitals & Biometrics dashboard": "Vitals & Biometrics dashboard",
   "yes": "Yes"
 }

packages/esm-patient-forms-app/src/index.ts

@@ -2,7 +2,6 @@ import {
   defineConfigSchema,
   getAsyncLifecycle,
   getSyncLifecycle,
-  registerBreadcrumbs,
   subscribePrecacheStaticDependencies,
   syncAllDynamicOfflineData,
 } from '@openmrs/esm-framework';
@@ -25,14 +24,6 @@ export const importTranslation = require.context('../translations', false, /.jso
 export function startupApp() {
   defineConfigSchema(moduleName, configSchema);
 
-  registerBreadcrumbs([
-    {
-      path: `${window.spaBase}/offline-tools/forms`,
-      title: 'Offline forms',
-      parent: `${window.spaBase}/offline-tools`,
-    },
-  ]);
-
   setupPatientFormSync();
   setupDynamicFormDataHandler();
   subscribePrecacheStaticDependencies(() => syncAllDynamicOfflineData('form'));