(test) O3-2106: Set up patient chart repo for e2e testing #1164

RandilaP · 2023-05-22T05:17:56Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
My work includes tests or is validated by existing tests.

Summary

Sets up patient chart repository for e2e testing using playwright.

Related Issue

https://issues.openmrs.org/browse/O3-2106

RandilaP · 2023-05-22T05:18:30Z

@jayasanka-sack @anjula-sack @Piumal1999 Could you please review this

e2e/fixtures/api.ts

vasharma05 · 2023-05-22T05:30:23Z

e2e/fixtures/api.ts

+      username: process.env.E2E_USER_ADMIN_USERNAME,
+      password: process.env.E2E_USER_ADMIN_PASSWORD,
+    },


For patient chart, we should also emphasize on role testings as well, i.e. Nurse/ Doctor, etc.

For patient chart, we should also emphasize on role testings as well, i.e. Nurse/ Doctor, etc.

How can I find those roles? can you explain it, please? For now this is an initial PR. So for now I was trying to use only the admin

e2e/storageState.json

playwright.config.ts

anjula-sack · 2023-05-23T17:41:15Z

.github/workflows/e2e.yml

+          path: playwright-report/
+          retention-days: 30
+
+  testOnPush:


@jayasanka-sack Why are we using camel case here?

Suggested change

testOnPush:

test-on-push:

No specific reason.

I prefer test-on-push: to maintain the same syntax throughout the yml file @jayasanka-sack

jayasanka-sack

Hey @RandilaP, thanks for the PR!

Please take a look at the comments. Also, could you kindly write a test case for this PR?

RandilaP · 2023-05-26T22:19:57Z

Hey @RandilaP, thanks for the PR!

Please take a look at the comments. Also, could you kindly write a test case for this PR?

@jayasanka-sack Sure. Thanks

jayasanka-sack · 2023-05-27T11:37:50Z

That makes sense

On Sat, 27 May 2023 at 17:07, Anjula Shanaka ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/e2e.yml <#1164 (comment)> : > + + - name: Run dev server + run: yarn start --sources 'packages/esm-*-app/' --port 8180 & # Refer to O3-1994 + + - name: Run E2E tests + run: yarn playwright test + + - name: Upload Report + uses: ***@***.*** + if: always() + with: + name: playwright-report + path: playwright-report/ + retention-days: 30 + + testOnPush: I prefer test-on-push: to maintain the same syntax throughout the yml file @jayasanka-sack <https://github.com/jayasanka-sack> — Reply to this email directly, view it on GitHub <#1164 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH4EOS6K7FS2QZEWTQTNFZTXIHROHANCNFSM6AAAAAAYJ452BU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Jayasanka Weerasinghe

RandilaP · 2023-05-29T09:53:35Z

@jayasanka-sack @anjula-sack @Piumal1999 Could you please review this

anjula-sack

@RandilaP can you resolve the conflicts?

Piumal1999 · 2023-05-29T14:10:09Z

package.json

-    "verify": "turbo run lint && turbo run typescript && yarn run test",
-    "prettier": "prettier --config prettier.config.js --write \"packages/**/*.{ts,tsx}\"",
-    "postinstall": "husky install",
+    "verify": "turbo run lint && turbo run typescript",
+    "prettier": "prettier --config prettier.config.js --write \"packages/**/*.{ts,tsx,css,scss}\" \"e2e/**/*.ts\"",


Do we need these changes?

e2e/specs/initiateTest.spec.ts

anjula-sack

@RandilaP the conflicts are still there

RandilaP · 2023-06-03T15:34:56Z

@jayasanka-sack @anjula-sack @Piumal1999 Could you please review this

.github/workflows/e2e.yml

anjula-sack · 2023-06-03T15:41:12Z

package.json

+    "verify": "turbo run lint && turbo run typescript",
+    "prettier": "prettier --config prettier.config.js --write \"packages/**/*.{ts,tsx,css,scss}\" \"e2e/**/*.ts\"",
+    "test": "cross-env TZ=UTC jest --config jest.config.json --verbose false --passWithNoTests",
+    "test-watch": "cross-env TZ=UTC jest --watch --config jest.config.json",
    "coverage": "yarn test --coverage",
-    "ci:bump-form-engine-lib": "yarn up @openmrs/openmrs-form-engine-lib@next"
+    "ci:bump-form-engine-lib": "yarn up @openmrs/openmrs-form-engine-lib@next",
+    "test-e2e": "playwright test",
+    "postinstall": "husky install"


Double check the changes here. Revert the unwanted changes

package.json

.github/workflows/e2e.yml

e2e/commands/patientOperations.ts

anjula-sack

Thank you! @RandilaP

This is done

vasharma05 reviewed May 22, 2023

View reviewed changes

Piumal1999 reviewed May 22, 2023

View reviewed changes

e2e/storageState.json Outdated Show resolved Hide resolved

anjula-sack suggested changes May 22, 2023

View reviewed changes

playwright.config.ts Outdated Show resolved Hide resolved

anjula-sack reviewed May 23, 2023

View reviewed changes

jayasanka-sack requested changes May 26, 2023

View reviewed changes

anjula-sack suggested changes May 29, 2023

View reviewed changes

Piumal1999 reviewed May 29, 2023

View reviewed changes

anjula-sack suggested changes May 29, 2023

View reviewed changes

e2e/specs/initiateTest.spec.ts Outdated Show resolved Hide resolved

anjula-sack suggested changes Jun 3, 2023

View reviewed changes

.github/workflows/e2e.yml Show resolved Hide resolved

anjula-sack suggested changes Jun 3, 2023

View reviewed changes

RandilaP added 14 commits June 4, 2023 16:47

Set up the patient chart repo for e2e testing

adce7c9

Set up the patient chart repo for e2e testing

40ba1fb

Making some changes

d13116c

Making some changes

90c20a7

Add requested changes

fc868a7

Add a initiative test

b3a66ed

Adjust initiative test

412ac86

Add allergies page and a test

953a6a9

Add some changes in package.json

86502b4

Resolve the merge conflict

83af5cc

Adjust some changes

0ad3e12

Adjust some changes

8cabf85

Add some adjustments

c4cc72d

Add requested changes

e983305

RandilaP added 2 commits June 4, 2023 16:52

Make some adjustments

74ebe04

Adjust some changes

42d4ccc

RandilaP force-pushed the O3-2106 branch from 64888de to 42d4ccc Compare June 4, 2023 11:30

jayasanka-sack previously requested changes Jun 4, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

jayasanka-sack reviewed Jun 4, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

jayasanka-sack reviewed Jun 4, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

RandilaP added 4 commits June 4, 2023 18:11

Adjust required changes

bcf5aaf

Adjust jest file

bac8cb2

Adjust requested changes

33dc0d9

Add yarn lock

ade211f

jayasanka-sack reviewed Jun 4, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

Update dependency cache key

fd14096

jayasanka-sack reviewed Jun 4, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

Update .github/workflows/e2e.yml

c85171e

anjula-sack reviewed Jun 4, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

anjula-sack changed the title ~~(fix) O3 2106: Set up patient chart repo for e2e testing~~ (test) O3-2106: Set up patient chart repo for e2e testing Jun 4, 2023

RandilaP added 2 commits June 4, 2023 23:27

Add requested changes

738d33b

Add requested changes

1e55822

anjula-sack reviewed Jun 5, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

RandilaP force-pushed the O3-2106 branch from 621d59e to 1e55822 Compare June 5, 2023 11:49

Remove cache dependecies

708a450

anjula-sack reviewed Jun 5, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

anjula-sack suggested changes Jun 5, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

denniskigen reviewed Jun 5, 2023

View reviewed changes

e2e/commands/patientOperations.ts Outdated Show resolved Hide resolved

e2e/commands/patientOperations.ts Outdated Show resolved Hide resolved

e2e/commands/patientOperations.ts Outdated Show resolved Hide resolved

RandilaP added 2 commits June 6, 2023 18:53

adjust required changes

f759954

Adjust required changes

ac59bcb

RandilaP force-pushed the O3-2106 branch from 709fd03 to ac59bcb Compare June 6, 2023 13:37

anjula-sack approved these changes Jun 6, 2023

View reviewed changes

anjula-sack merged commit c425bb5 into openmrs:main Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(test) O3-2106: Set up patient chart repo for e2e testing #1164

(test) O3-2106: Set up patient chart repo for e2e testing #1164

RandilaP commented May 22, 2023 •

edited by denniskigen

Loading

RandilaP commented May 22, 2023

vasharma05 May 22, 2023

RandilaP May 22, 2023 •

edited

Loading

anjula-sack May 23, 2023

jayasanka-sack May 26, 2023

anjula-sack May 27, 2023

jayasanka-sack left a comment

RandilaP commented May 26, 2023

jayasanka-sack commented May 27, 2023 via email

RandilaP commented May 29, 2023

anjula-sack left a comment

Piumal1999 May 29, 2023

anjula-sack left a comment

RandilaP commented Jun 3, 2023

anjula-sack Jun 3, 2023

anjula-sack left a comment

(test) O3-2106: Set up patient chart repo for e2e testing #1164

(test) O3-2106: Set up patient chart repo for e2e testing #1164

Conversation

RandilaP commented May 22, 2023 • edited by denniskigen Loading

Requirements

Summary

Related Issue

RandilaP commented May 22, 2023

vasharma05 May 22, 2023

Choose a reason for hiding this comment

RandilaP May 22, 2023 • edited Loading

Choose a reason for hiding this comment

anjula-sack May 23, 2023

Choose a reason for hiding this comment

jayasanka-sack May 26, 2023

Choose a reason for hiding this comment

anjula-sack May 27, 2023

Choose a reason for hiding this comment

jayasanka-sack left a comment

Choose a reason for hiding this comment

RandilaP commented May 26, 2023

jayasanka-sack commented May 27, 2023 via email

RandilaP commented May 29, 2023

anjula-sack left a comment

Choose a reason for hiding this comment

Piumal1999 May 29, 2023

Choose a reason for hiding this comment

anjula-sack left a comment

Choose a reason for hiding this comment

RandilaP commented Jun 3, 2023

anjula-sack Jun 3, 2023

Choose a reason for hiding this comment

anjula-sack left a comment

Choose a reason for hiding this comment

RandilaP commented May 22, 2023 •

edited by denniskigen

Loading

RandilaP May 22, 2023 •

edited

Loading