(feat) Add translations for generic widget and patient chart pagination #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.06 kB (0%) Total Size: 9.06 MB ℹ️ View Unchanged
|
…ient-chart into pagination-generic-translations
…ient-chart into pagination-generic-translations
|
Hi @icrc-jofrancisco , there are a few additions. |
|
Hi @ibacher @denniskigen , requesting your review here. |
denniskigen
changed the title
denniskigen
changed the title
denniskigen
reviewed
Oct 5, 2023
denniskigen
previously approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Looks OK to me. Thanks, @vasharma05. It'd be nice if we could add locale specific translations for the few new strings introduced here to obviate the need for a future PR.
|
Hi @kazlaw @icrc-jofrancisco @AlexanderMizgirev , I request your assistance here to add the new translations. |
…ient-chart into pagination-generic-translations
…com/openmrs/openmrs-esm-patient-chart into pagination-generic-translations
3 tasks
…ient-chart into pagination-generic-translations
…com/openmrs/openmrs-esm-patient-chart into pagination-generic-translations
…ient-chart into pagination-generic-translations
denniskigen
approved these changes
Oct 17, 2023
Comment on lines
39
to
40
| * THE TRANSLATION KEYS AND VALUES USED IN THE COMMON LIB IS WRITTEN HERE | ||
| * t('paginationPageText', 'of {total} pages') |
There was a problem hiding this comment.
Suggested change
| * THE TRANSLATION KEYS AND VALUES USED IN THE COMMON LIB IS WRITTEN HERE | |
| * t('paginationPageText', 'of {total} pages') | |
| * The following are translation keys and strings for components in `esm-patient-common-lib` | |
| * t('paginationPageText', 'of {total} pages') |
Comment on lines
39
to
+40
| * THE TRANSLATION KEYS AND VALUES USED IN THE COMMON LIB IS WRITTEN HERE | ||
| * t('paginationPageText', 'of {count} pages', {count}) |
There was a problem hiding this comment.
Suggested change
| * THE TRANSLATION KEYS AND VALUES USED IN THE COMMON LIB IS WRITTEN HERE | |
| * t('paginationPageText', 'of {count} pages', {count}) | |
| * The following are translation keys and strings for components in `esm-patient-common-lib` | |
| * t('paginationPageText', 'of {total} pages') |
There was a problem hiding this comment.
Hi @denniskigen !
The count variable is used for pluralization purpose, and hence it was renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds the translations for generic widget and patient chart pagination component
Screenshots
Related Issue
Other