(feat) O3-2485: Allow view only field for visit location in the start visit form #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +517 B (0%) Total Size: 9.1 MB ℹ️ View Unchanged
|
…ient-chart into feat/view-only-visit-location-field
…hub.com/openmrs/openmrs-esm-patient-chart into feat/view-only-visit-location-field
…ient-chart into feat/view-only-visit-location-field
denniskigen
reviewed
Oct 19, 2023
denniskigen
reviewed
Oct 19, 2023
| @@ -10,6 +10,7 @@ | |||
| "editFlags": "Editar banderas", | |||
| "enabledFlag": "Bandera activada", | |||
| "enablingFlag": "Activando bandera...", | |||
| "flagCountfalsemany": "{count} risk flag{plural}", | |||
There was a problem hiding this comment.
Does #1413 solve the issue of this specific translation randomly showing up in unrelated diffs? Perhaps rebasing against main might fix it?
There was a problem hiding this comment.
This actually is the wrong key, instead of false, it should be _
denniskigen
previously approved these changes
Oct 19, 2023
…ient-chart into feat/view-only-visit-location-field
…hub.com/openmrs/openmrs-esm-patient-chart into feat/view-only-visit-location-field
brandones
requested changes
Oct 20, 2023
packages/esm-patient-chart-app/src/visit/visit-form/location-selection.component.tsx
Outdated
Show resolved
Hide resolved
brandones
approved these changes
Oct 20, 2023
vasharma05
commented
Oct 20, 2023
| /> | ||
| )} | ||
| /> | ||
| {!viewOnlyVisitLocationField ? ( |
There was a problem hiding this comment.
Hi @brandones !
I see that the config prop was renamed but it wasn't updated in here.
I'll create a new PR for this.
Thank you for the changes and review @brandones @denniskigen !
There was a problem hiding this comment.
Oh no, I'm sorry I missed that. My bad. Thank you Vineet.
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds a new configuration point to the Patient Chart's configuration schema. This property determines whether the
Visit locationfield in the Start Visit form is editable or read-only. By default, the value of the field gets resolved to the value of the logged-in user'ssessionLocationproperty.Sample configuration (set to
falseso the input is editable by default):Screenshots
Design was confirmed with Ciaran in the slack thread here
Related Issue
https://issues.openmrs.org/projects/O3/issues/O3-2485
Other
None