-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Update encounter date to pick visitStartDatetime #1405
Conversation
Size Change: +247 B (0%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
I think we need to be hesitant about features like this as they do not work for all use-cases. Specifically, some implementations will need multi day visits, and this will result in encounters being recorded at incorrect times in this cases. If we can setup a way that implementations can opt-in to this feature, it’s ok, but I don’t think we should merge this as is. |
a310b17
to
008c9c2
Compare
@ibacher we have made this an opt in feature |
acd68a5
to
a66405b
Compare
packages/esm-form-entry-app/src/app/form-creation/form-creation.service.ts
Outdated
Show resolved
Hide resolved
a66405b
to
8cd3826
Compare
Requirements
Summary
This PR updates the default value of encounterDate on the form to default to
visitStartDatetime
if thevisitStartDatetime
is beforecurrent Date
Screenshots
Related Issue
https://thepalladiumgroup.atlassian.net/browse/KHP3-4256
Other